Add CSS agent for various window/widget/view attributes in devtools

Add CSS agent for various window/widget/view attributes in devtools

This CL adds a few things:
- Three maps in DOM agent which map from the node Id to a window, widget
or view.
- Public methods to query these three maps.
- CSS Agent which receives the getMatchedStylesForNode command whenever a
node is selected in the inspector. The CSS Agent queries which object
the nodeId refers to using the passed in DOM agent and builds the CSS
object for it. For now, the only attributes this will show is bounds
height and width.
- protocol.json modified for the new CSS Agent

BUG=648701
Committed: https://crrev.com/614f26621199fe032a65224b010f0d74f6969835
Cr-Commit-Position: refs/heads/master@{#432761}

[Sarmad Hashmi, 2016-11-08 01:58:12]

The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 01:58:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 03:25:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 03:25:20]

Dry run: This issue passed the CQ dry run.

[Sarmad Hashmi, 2016-11-08 17:37:54]

mhashmi@chromium.org changed reviewers:
+ sadrul@chromium.org

[Sarmad Hashmi, 2016-11-08 17:37:54]

PTAL sadrul! If you think this is too large, please do let me know and I'll
split it up.

[Sarmad Hashmi, 2016-11-08 17:48:57]

The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 17:49:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 18:56:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 18:56:21]

Dry run: This issue passed the CQ dry run.

[Sarmad Hashmi, 2016-11-08 22:36:36]

The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 22:37:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 23:46:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 23:46:46]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-11-09 16:47:46]

https://codereview.chromium.org/2486543003/diff/60001/ash/common/devtools/ash...
File ash/common/devtools/ash_devtools_dom_agent.cc (right):

https://codereview.chromium.org/2486543003/diff/60001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_dom_agent.cc:207:
window_to_node_id_map_.erase(it);
Remove node_id from node_id_to_window_map_?

Should this also go find window->GetInternalWidget(), and remove from
node_id_to_widget_map_, and node_id_to_view_map_ too? (i.e. a reverse of
BuildTreeForWindow())

[Sarmad Hashmi, 2016-11-09 20:48:38]

The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 20:48:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sarmad Hashmi, 2016-11-09 20:51:38]

https://codereview.chromium.org/2486543003/diff/60001/ash/common/devtools/ash...
File ash/common/devtools/ash_devtools_dom_agent.cc (right):

https://codereview.chromium.org/2486543003/diff/60001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_dom_agent.cc:207:
window_to_node_id_map_.erase(it);
On 2016/11/09 16:47:46, sadrul wrote:
> Remove node_id from node_id_to_window_map_?
> 
> Should this also go find window->GetInternalWidget(), and remove from
> node_id_to_widget_map_, and node_id_to_view_map_ too? (i.e. a reverse of
> BuildTreeForWindow())

Yes! Done. I'm not doing the removal of views in this CL because it'll crash
unless we add observers (for view adding/removing) so that newly added views are
mapped and can safely be removed. Same with widgets, but that doesn't cause a
crash because you can't have a widget without a window being created.

[commit-bot: I haz the power, 2016-11-09 21:38:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 21:38:46]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-11-10 20:34:15]

lgtm

https://codereview.chromium.org/2486543003/diff/80001/ash/common/devtools/ash...
File ash/common/devtools/ash_devtools_css_agent.cc (right):

https://codereview.chromium.org/2486543003/diff/80001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_css_agent.cc:34:
std::unique_ptr<Array<CSS::CSSProperty>> cssProperties =
You can use auto here if you want.

https://codereview.chromium.org/2486543003/diff/80001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_css_agent.cc:37:
cssProperties->addItem(BuildCSSProperty("width", bounds.width()));
Add "x" and "y" too?

https://codereview.chromium.org/2486543003/diff/80001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_css_agent.cc:43:
std::unique_ptr<Array<CSS::ShorthandEntry>> shorthandEntries =
ditto

https://codereview.chromium.org/2486543003/diff/80001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_css_agent.cc:61:
BuildBoundsShorthandEntryArray(bounds));
What is the 'shorthand entry' list?

[Sarmad Hashmi, 2016-11-15 17:02:02]

Could you take a last look for the shorthandEntry stuff?

https://codereview.chromium.org/2486543003/diff/80001/ash/common/devtools/ash...
File ash/common/devtools/ash_devtools_css_agent.cc (right):

https://codereview.chromium.org/2486543003/diff/80001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_css_agent.cc:34:
std::unique_ptr<Array<CSS::CSSProperty>> cssProperties =
On 2016/11/10 20:34:14, sadrul wrote:
> You can use auto here if you want.

Done.

https://codereview.chromium.org/2486543003/diff/80001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_css_agent.cc:37:
cssProperties->addItem(BuildCSSProperty("width", bounds.width()));
On 2016/11/10 20:34:14, sadrul wrote:
> Add "x" and "y" too?

Done.

https://codereview.chromium.org/2486543003/diff/80001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_css_agent.cc:43:
std::unique_ptr<Array<CSS::ShorthandEntry>> shorthandEntries =
On 2016/11/10 20:34:14, sadrul wrote:
> ditto

Removed this.

https://codereview.chromium.org/2486543003/diff/80001/ash/common/devtools/ash...
ash/common/devtools/ash_devtools_css_agent.cc:61:
BuildBoundsShorthandEntryArray(bounds));
On 2016/11/10 20:34:14, sadrul wrote:
> What is the 'shorthand entry' list?

Frontend requires us to pass this. I took out ShorthandEntry and just passed an
empty string array. Added this to the protocol.json description as well.

[Sarmad Hashmi, 2016-11-15 17:05:53]

The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 17:06:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 18:36:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 18:36:45]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-11-16 00:17:27]

still lgtm

[Sarmad Hashmi, 2016-11-16 20:56:18]

The CQ bit was checked by mhashmi@chromium.org

[Sarmad Hashmi, 2016-11-16 20:56:19]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2486543003/#ps120001
(title: "sadruls comments")

[commit-bot: I haz the power, 2016-11-16 20:56:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 21:39:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 21:39:02]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Sarmad Hashmi, 2016-11-16 21:45:16]

mhashmi@chromium.org changed reviewers:
+ sky@chromium.org

[Sarmad Hashmi, 2016-11-16 21:45:17]

+sky for ash OWNERS review

[sky, 2016-11-17 00:17:21]

LGTM

[Sarmad Hashmi, 2016-11-17 03:59:24]

The CQ bit was checked by mhashmi@chromium.org

[commit-bot: I haz the power, 2016-11-17 04:00:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 05:25:29]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-11-17 05:29:25]

Description was changed from

==========
Add CSS agent for various window/widget/view attributes in devtools

This CL adds a few things:
- Three maps in DOM agent which map from the node Id to a window, widget
or view.
- Public methods to query these three maps.
- CSS Agent which receives the getMatchedStylesForNode command whenever a
node is selected in the inspector. The CSS Agent queries which object
the nodeId refers to using the passed in DOM agent and builds the CSS
object for it. For now, the only attributes this will show is bounds
height and width.
- protocol.json modified for the new CSS Agent

BUG=648701
==========

to

==========
Add CSS agent for various window/widget/view attributes in devtools

This CL adds a few things:
- Three maps in DOM agent which map from the node Id to a window, widget
or view.
- Public methods to query these three maps.
- CSS Agent which receives the getMatchedStylesForNode command whenever a
node is selected in the inspector. The CSS Agent queries which object
the nodeId refers to using the passed in DOM agent and builds the CSS
object for it. For now, the only attributes this will show is bounds
height and width.
- protocol.json modified for the new CSS Agent

BUG=648701

Committed: https://crrev.com/614f26621199fe032a65224b010f0d74f6969835
Cr-Commit-Position: refs/heads/master@{#432761}
==========

[commit-bot: I haz the power, 2016-11-17 05:29:26]

Patchset 7 (id:??) landed as
https://crrev.com/614f26621199fe032a65224b010f0d74f6969835
Cr-Commit-Position: refs/heads/master@{#432761}