[Mojo Video Capture] Add test ReceiveFramesFromFakeCaptureDevice

services/video_capture/device_factory_media_to_mojo_adapter.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/video_capture/device_factory_media_to_mojo_adapter.h"
 
 #include <sstream>
 
 #include "base/logging.h"
 #include "base/strings/stringprintf.h"
@@ skipping 30 matching lines @@
     const EnumerateDeviceDescriptorsCallback& callback) {
   media::VideoCaptureDeviceDescriptors descriptors;
   device_factory_->GetDeviceDescriptors(&descriptors);
   callback.Run(descriptors);
 }
 
 void DeviceFactoryMediaToMojoAdapter::GetSupportedFormats(
     const media::VideoCaptureDeviceDescriptor& device_descriptor,
     const GetSupportedFormatsCallback& callback) {
   std::vector<VideoCaptureFormat> result;
-  NOTIMPLEMENTED();
+  std::vector<media::VideoCaptureFormat> media_formats;
+  device_factory_->GetSupportedFormats(device_descriptor, &media_formats);
+  for (const auto& media_format : media_formats) {
+    // The Video Capture Service requires devices to deliver frames either in
+    // I420 or MJPEG formats.
+    if (media_format.pixel_format != media::PIXEL_FORMAT_I420 &&
+        media_format.pixel_format != media::PIXEL_FORMAT_MJPEG)

[mcasas, 2016/11/09 23:50:29]

Y16 was added very recently to FakeVCD and Win [1]
to support depth-cameras, perhaps you should add 
it here as well ?

[1]
https://cs.chromium.org/search/?q=PIXEL_FORMAT_Y16+media/capture/video&sq=pac...

[chfremer, 2016/11/10 00:28:48]

Thanks for the heads up. 
I have already seen and merged in some of the Y16 code changes.
For the Mojo service, please allow me to defer adding the Y16 until we get
closer to the point where we are actually going to connect it to
VideoCaptureController. I will add a work item in the design doc to ensure we
add the support for Y16 before we connect it.

[mcasas, 2016/11/10 01:21:25]

Alright. If it's in a few places (ideally, one), just add a 
TODO to link to the bug 624436.

[chfremer, 2016/11/10 04:41:35]

Done.

+      continue;
+    VideoCaptureFormat format;
+    format.frame_size = media_format.frame_size;
+    format.frame_rate = media_format.frame_rate;
+    if (std::find(std::begin(result), std::end(result), format) !=
+        std::end(result))
+      continue;  // Result already contains this format

[mcasas, 2016/11/09 23:50:29]

{} because the if() condition expands > 1 line.

[chfremer, 2016/11/10 00:28:48]

Done.

+    result.push_back(format);
+  }
   callback.Run(std::move(result));
 }
 
 void DeviceFactoryMediaToMojoAdapter::CreateDeviceProxy(
     const media::VideoCaptureDeviceDescriptor& device_descriptor,
     mojom::VideoCaptureDeviceProxyRequest proxy_request,
     const CreateDeviceProxyCallback& callback) {
   if (active_devices_.find(device_descriptor) != active_devices_.end()) {
     // The requested device is already in use.
     // Revoke the access and close the device, then bind to the new request.
@@ skipping 30 matching lines @@
   callback.Run(mojom::DeviceAccessResultCode::SUCCESS);
 }
 
 void DeviceFactoryMediaToMojoAdapter::OnClientConnectionErrorOrClose(
     const media::VideoCaptureDeviceDescriptor& descriptor) {
   active_devices_[descriptor].device_proxy->Stop();
   active_devices_.erase(descriptor);
 }
 
 }  // namespace video_capture