Change code to not store Sk4* in data structures.

src/core/SkLinearBitmapPipeline_sample.h

 /*
  * Copyright 2016 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkLinearBitmapPipeline_sampler_DEFINED
 #define SkLinearBitmapPipeline_sampler_DEFINED
 
@@ skipping 47 matching lines @@
 template <SkColorType, SkGammaType> class PixelConverter;
 
 // Alpha handling:
 //   The alpha from the paint (tintColor) is used in the blend part of the pipeline to modulate
 // the entire bitmap. So, the tint color is given an alpha of 1.0 so that the later alpha can
 // modulate this color later.
 template <>
 class PixelConverter<kAlpha_8_SkColorType, kLinear_SkGammaType> {
 public:
     using Element = uint8_t;
-    PixelConverter(const SkPixmap& srcPixmap, SkColor tintColor)
-        : fTintColor{set_alpha(Sk4f_from_SkColor(tintColor), 1.0f)} { }
+    PixelConverter(const SkPixmap& srcPixmap, SkColor tintColor) {
+        set_alpha(Sk4f_from_SkColor(tintColor), 1.0f).store(&fTintColor);
+    }
 
     Sk4f toSk4f(const Element pixel) const {
-        return fTintColor * (pixel * (1.0f/255.0f));
+        return Sk4f::Load(&fTintColor) * (pixel * (1.0f/255.0f));
     }
 
 private:
-    const Sk4f fTintColor;
+    float fTintColor[4];

[mtklein_C, 2016/11/07 21:48:15]

This may be a good place to use SkColor4f.

[herb_g, 2016/11/08 14:59:34]

Done.

 };
 
 template <SkGammaType gammaType>
 static inline Sk4f pmcolor_to_rgba(SkPMColor pixel) {
     return swizzle_rb_if_bgra(
             (gammaType == kSRGB_SkGammaType) ? Sk4f_fromS32(pixel)
                                              : Sk4f_fromL32(pixel));
 }
 
 template <SkGammaType gammaType>
@@ skipping 940 matching lines @@
     const SkShader::TileMode fXEdgeType;
     const int                fXMax;
     const SkShader::TileMode fYEdgeType;
     const int                fYMax;
     Accessor                 fAccessor;
 };
 
 }  // namespace
 
 #endif  // SkLinearBitmapPipeline_sampler_DEFINED