Sync pdfium tryserver configs with main pdfium waterfall.

Sync pdfium tryserver configs with main pdfium waterfall.

BUG=pdfium:627
Committed: https://chromium.googlesource.com/chromium/tools/build/+/8e2ee248e819cf2272d40d46753d7389cc7a2b1a

[Lei Zhang, 2016-11-07 19:23:38]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 19:23:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-11-07 19:25:38]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 19:25:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-11-07 19:42:03]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 19:42:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 19:53:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 19:53:20]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-11-07 19:54:53]

thestig@chromium.org changed reviewers:
+ dpranke@chromium.org, weili@chromium.org

[Lei Zhang, 2016-11-07 19:54:53]

I put the configs in the same order as
masters/master.client.pdfium/builders.pyl, with the experimental skia trybots at
the end of the per-platform configs.

[Dirk Pranke, 2016-11-07 20:20:19]

lgtm

[Wei Li, 2016-11-07 20:41:32]

https://codereview.chromium.org/2486463002/diff/40001/masters/master.tryserve...
File masters/master.tryserver.client.pdfium/builders.pyl (right):

https://codereview.chromium.org/2486463002/diff/40001/masters/master.tryserve...
masters/master.tryserver.client.pdfium/builders.pyl:83: "linux_skia": {
Reordering is not necessary since whether to put a bot in experimental is a
decision made in config file on client side. the builder itself should not need
to be modified. WDYT?

[Lei Zhang, 2016-11-07 21:21:55]

https://codereview.chromium.org/2486463002/diff/40001/masters/master.tryserve...
File masters/master.tryserver.client.pdfium/builders.pyl (right):

https://codereview.chromium.org/2486463002/diff/40001/masters/master.tryserve...
masters/master.tryserver.client.pdfium/builders.pyl:83: "linux_skia": {
On 2016/11/07 20:41:32, Wei Li wrote:
> Reordering is not necessary since whether to put a bot in experimental is a
> decision made in config file on client side. the builder itself should not
need
> to be modified. WDYT? 

- The reordering certainly does not matter from the configuration perspective.
- The *_skia bots are not modified.
- I did it just so the ordering matches
masters/master.client.pdfium/builders.pyl better. In that file, the list is
[..., linux_no_v8, linux_xfa, ...] so I wanted the same here but with [...,
linux_no_v8, linux_xfa, ..., linux_skia] instead of [..., linux_no_v8,
linux_skia, linux_xfa, ...]

[Lei Zhang, 2016-11-07 21:24:22]

Or do we want to order them alphabetically? In which case [..., linux_no_v8,
linux_skia, linux_xfa, ...] is correct.

[Wei Li, 2016-11-07 21:33:40]

On 2016/11/07 21:24:22, Lei Zhang wrote:
> Or do we want to order them alphabetically? In which case [..., linux_no_v8,
> linux_skia, linux_xfa, ...] is correct.

Since builders file (this one) has no knowledge of bots being used experimental
or not,
it is better to order alphabetically.

[Lei Zhang, 2016-11-07 21:37:09]

On 2016/11/07 21:33:40, Wei Li wrote:
> On 2016/11/07 21:24:22, Lei Zhang wrote:
> > Or do we want to order them alphabetically? In which case [..., linux_no_v8,
> > linux_skia, linux_xfa, ...] is correct.
> 
> Since builders file (this one) has no knowledge of bots being used
experimental
> or not,
> it is better to order alphabetically.

Done.

[Lei Zhang, 2016-11-07 21:37:25]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 21:37:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 21:47:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 21:47:47]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-11-07 21:58:54]

lgtm

[Lei Zhang, 2016-11-07 22:04:35]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-11-07 22:04:35]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2486463002/#ps60001
(title: "alphabetical order")

[commit-bot: I haz the power, 2016-11-07 22:04:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 22:15:34]

Description was changed from

==========
Sync pdfium tryserver configs with main pdfium waterfall.

BUG=pdfium:627
==========

to

==========
Sync pdfium tryserver configs with main pdfium waterfall.

BUG=pdfium:627

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/8e2ee248e819cf2272d4...
==========

[commit-bot: I haz the power, 2016-11-07 22:15:35]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/tools/build/+/8e2ee248e819cf2272d4...