Add an environment variable toggle to control new service protocol auth token

Add an environment variable toggle to control new service protocol auth token

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/14297ee480d798bcc56955efeb1de6892e48b355

[Cutch, 2016-11-07 19:02:54]

Description was changed from

==========
Add an environment variable toggle to control new service protocol auth token

BUG=
==========

to

==========
Add an environment variable toggle to control new service protocol auth token

BUG=
==========

[Cutch, 2016-11-07 19:02:54]

johnmccutchan@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-11-07 21:34:41]

LGTM.

I am assuming there is another CL that adds some service tests to use this
option.

[Cutch, 2016-11-07 22:26:24]

PTAL

[siva, 2016-11-07 22:44:04]

lgtm

https://codereview.chromium.org/2486443002/diff/20001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/2486443002/diff/20001/runtime/bin/main.cc#new...
runtime/bin/main.cc:860: CHECK_RESULT(result);
I am wondering if we should just hoist these two lines
SetupPackageRoot
 and
Dart_SetEnvironmentCallback
above the check
if (Dart_IsServiceIsolate(isolate)) {
  ....
  ....
}

How does the service isolate deal with packages without having the
package root setup ?

[Cutch, 2016-11-07 22:45:57]

Description was changed from

==========
Add an environment variable toggle to control new service protocol auth token

BUG=
==========

to

==========
Add an environment variable toggle to control new service protocol auth token

BUG=
R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/14297ee480d798bcc56955efeb1de6892e48b355
==========

[Cutch, 2016-11-07 22:45:58]

Committed patchset #2 (id:20001) manually as
14297ee480d798bcc56955efeb1de6892e48b355 (presubmit successful).