Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2486433004: X87: [builtins]: Uniformly push argument count in TF-generated builtins. (Closed)

Created:
4 years, 1 month ago by zhengxing.li
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins]: Uniformly push argument count in TF-generated builtins. port 4447405b179db63748c10d8cb3d139e795195eb3 (r40712) original commit message: BUG= Committed: https://crrev.com/a457336dbf24a365de6a1c313fe0147f504ecb6e Cr-Commit-Position: refs/heads/master@{#40816}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 1 month ago (2016-11-08 02:30:17 UTC) #2
Weiliang
lgtm
4 years, 1 month ago (2016-11-08 02:35:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486433004/1
4 years, 1 month ago (2016-11-08 02:42:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 03:08:09 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:25:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a457336dbf24a365de6a1c313fe0147f504ecb6e
Cr-Commit-Position: refs/heads/master@{#40816}

Powered by Google App Engine
This is Rietveld 408576698