Add data usage tracking for GAIA auth api and GCM engine service

Add data usage tracking for GAIA auth api

BUG=655749

[Raj, 2016-11-09 23:55:23]

rajendrant@chromium.org changed reviewers:
+ zelidrag@chromium.org

[Raj, 2016-11-09 23:55:24]

zelidrag: ptal  google_apis/gaia/*

[zel, 2016-11-10 01:13:29]

lgtm

[Raj, 2016-11-10 21:34:43]

rajendrant@chromium.org changed reviewers:
+ kundaji@chromium.org, rkaplow@chromium.org, zea@chromium.org

[Raj, 2016-11-10 21:34:43]

zea: ptal google_apis/gcm/engine/*

kundaji: ptal components/data_use_measurement/core/*

rkaplow: tools/metrics/histograms/histograms.xml

[Raj, 2016-11-10 21:35:00]

Description was changed from

==========
Add data usage tracking for GAIA auth api

BUG=655749
==========

to

==========
Add data usage tracking for GAIA auth api

BUG=655749
==========

[Nicolas Zea, 2016-11-10 21:38:12]

https://codereview.chromium.org/2486423002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2486423002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:78947: +  <int value="23" label="GAIA
Auth Fetcher"/>
Should the GCM engine also be here?

[Raj, 2016-11-10 21:43:23]

https://codereview.chromium.org/2486423002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2486423002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:78947: +  <int value="23" label="GAIA
Auth Fetcher"/>
On 2016/11/10 21:38:12, Nicolas Zea wrote:
> Should the GCM engine also be here?

Thanks. Added it.

[Nicolas Zea, 2016-11-10 22:41:25]

gcm LGTM. FYI, most of GCM's traffic is TCP (via GCM's ConnectionFactory), not
HTTP. Not sure if that's something you eventually plan to capture.

[rkaplow, 2016-11-10 23:22:58]

lgtm

[Not at Google. Contact bengr, 2016-11-11 00:12:26]

data_use_measurement/* LGTM.

[Not at Google. Contact bengr, 2016-11-11 00:12:28]

lgtm

data_use_measurement/* LGTM.

[Raj, 2016-11-11 01:11:53]

The CQ bit was checked by rajendrant@chromium.org

[Raj, 2016-11-11 01:11:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
zelidrag@chromium.org
Link to the patchset: https://codereview.chromium.org/2486423002/#ps40001
(title: "Add GCM engine to histograms.xml")

[commit-bot: I haz the power, 2016-11-11 01:12:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 01:18:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 01:18:19]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Raj, 2016-11-11 18:24:47]

The CQ bit was checked by rajendrant@chromium.org

[Raj, 2016-11-11 18:24:47]

The patchset sent to the CQ was uploaded after l-g-t-m from zea@chromium.org,
kundaji@chromium.org, rkaplow@chromium.org, zelidrag@chromium.org
Link to the patchset: https://codereview.chromium.org/2486423002/#ps60001
(title: "Fixed DEPS")

[commit-bot: I haz the power, 2016-11-11 18:25:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 18:35:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 18:35:56]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Raj, 2016-11-11 19:49:00]

rajendrant@chromium.org changed reviewers:
+ rogerta@chromium.org

[Raj, 2016-11-11 19:49:00]

rogerta: ptal google_apis/DEPS

[Roger Tawa OOO till Jul 10th, 2016-11-15 20:30:04]

DEPS from //google_apis to //components are not allowed.  Looking more closely
at this CL, it seems the new dependency is for an enum value and a one-line
wrapper function to call a URLFetcher method.

I'd suggest breaking up the data usage tracking code into two parts.  See
metrics for a good example: one part lives in //base/metrics and is included by
all, and another lives in //components/metrics and does the heavy lifting.

Does that make sense?

[Raj, 2016-11-16 18:33:33]

On 2016/11/15 20:30:04, Roger Tawa wrote:
> DEPS from //google_apis to //components are not allowed.  Looking more closely
> at this CL, it seems the new dependency is for an enum value and a one-line
> wrapper function to call a URLFetcher method.
> 
> I'd suggest breaking up the data usage tracking code into two parts.  See
> metrics for a good example: one part lives in //base/metrics and is included
by
> all, and another lives in //components/metrics and does the heavy lifting.
> 
> Does that make sense?

Thanks.
I will work on moving datause tracking to //net/

[Roger Tawa OOO till Jul 10th, 2017-01-12 12:56:26]

rogerta@chromium.org changed reviewers:
- rogerta@chromium.org