Split positionAndLayoutFloat() off positionNewFloats().

Split positionAndLayoutFloat() off positionNewFloats().

Float layout is somewhat broken when it comes to fragmentation (multicol,
printing). We're going to have to make sure that we always position the
float before laying it out, and, after layout, insert a break before it if
needed. This is a preparatory CL for that.

We currently lay out a float e.g. in insertFloatingObject() without
worrying about setting the position first.

No behavior changes intended.

BUG=663942
Committed: https://crrev.com/d108b2435612ff0bf1f2d88e79f798b691889df2
Cr-Commit-Position: refs/heads/master@{#431422}

[mstensho (USE GERRIT), 2016-11-09 23:41:13]

Description was changed from

==========
Split positionAndLayoutFloat() off positionNewFloats().

Float layout is somewhat broken when it comes to fragmentation (multicol,
printing), and we're going to have to make sure that we always position the
float before laying it out, and, after layout, insert a break before it if
needed. This is a preparatory CL for that.

No behavior changes intended.

BUG=663942
==========

to

==========
Split positionAndLayoutFloat() off positionNewFloats().

Float layout is somewhat broken when it comes to fragmentation (multicol,
printing). We're going to have to make sure that we always position the
float before laying it out, and, after layout, insert a break before it if
needed. This is a preparatory CL for that.

We currently lay out a float e.g. in insertFloatingObject() without
worrying about setting the position first.

No behavior changes intended.

BUG=663942
==========

[mstensho (USE GERRIT), 2016-11-09 23:41:13]

mstensho@opera.com changed reviewers:
+ szager@chromium.org

[szager1, 2016-11-10 20:56:58]

lgtm

[mstensho (USE GERRIT), 2016-11-10 20:59:17]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2016-11-10 20:59:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 00:43:25]

Description was changed from

==========
Split positionAndLayoutFloat() off positionNewFloats().

Float layout is somewhat broken when it comes to fragmentation (multicol,
printing). We're going to have to make sure that we always position the
float before laying it out, and, after layout, insert a break before it if
needed. This is a preparatory CL for that.

We currently lay out a float e.g. in insertFloatingObject() without
worrying about setting the position first.

No behavior changes intended.

BUG=663942
==========

to

==========
Split positionAndLayoutFloat() off positionNewFloats().

Float layout is somewhat broken when it comes to fragmentation (multicol,
printing). We're going to have to make sure that we always position the
float before laying it out, and, after layout, insert a break before it if
needed. This is a preparatory CL for that.

We currently lay out a float e.g. in insertFloatingObject() without
worrying about setting the position first.

No behavior changes intended.

BUG=663942
==========

[commit-bot: I haz the power, 2016-11-11 00:43:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-11 00:45:56]

Description was changed from

==========
Split positionAndLayoutFloat() off positionNewFloats().

Float layout is somewhat broken when it comes to fragmentation (multicol,
printing). We're going to have to make sure that we always position the
float before laying it out, and, after layout, insert a break before it if
needed. This is a preparatory CL for that.

We currently lay out a float e.g. in insertFloatingObject() without
worrying about setting the position first.

No behavior changes intended.

BUG=663942
==========

to

==========
Split positionAndLayoutFloat() off positionNewFloats().

Float layout is somewhat broken when it comes to fragmentation (multicol,
printing). We're going to have to make sure that we always position the
float before laying it out, and, after layout, insert a break before it if
needed. This is a preparatory CL for that.

We currently lay out a float e.g. in insertFloatingObject() without
worrying about setting the position first.

No behavior changes intended.

BUG=663942

Committed: https://crrev.com/d108b2435612ff0bf1f2d88e79f798b691889df2
Cr-Commit-Position: refs/heads/master@{#431422}
==========

[commit-bot: I haz the power, 2016-11-11 00:45:57]

Patchset 1 (id:??) landed as
https://crrev.com/d108b2435612ff0bf1f2d88e79f798b691889df2
Cr-Commit-Position: refs/heads/master@{#431422}

[mstensho (USE GERRIT), 2016-11-16 10:18:59]

https://codereview.chromium.org/2486413002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp (right):

https://codereview.chromium.org/2486413002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp:3640:
positionAndLayoutFloat(floatingObject, logicalTop);
Oops! Forgot to actually update logicalTop here. positionAndLayoutFloat()
returns a new logical top, but we currently just ignore it.

[mstensho (USE GERRIT), 2016-11-16 10:28:13]

https://codereview.chromium.org/2486413002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp (right):

https://codereview.chromium.org/2486413002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp:3640:
positionAndLayoutFloat(floatingObject, logicalTop);
On 2016/11/16 10:18:59, mstensho wrote:
> Oops! Forgot to actually update logicalTop here. positionAndLayoutFloat()
> returns a new logical top, but we currently just ignore it.

See crbug.com/665804