Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2486393006: Include the source_to_parent offset when removing offset applied by main. (Closed)

Created:
4 years, 1 month ago by flackr
Modified:
4 years, 1 month ago
Reviewers:
ajuma, weiliangc
CC:
blink-reviews, cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include the source_to_parent offset when removing offset applied by main. BUG=663642 TEST=LayerTreeHostCommonTest.StickyPositionTopScrollParent, compositing/overflow/composited-sticky-element.html CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/d2ae03fccb90a1de08a12be2c9d81cf4ff04f713 Cr-Commit-Position: refs/heads/master@{#431898}

Patch Set 1 #

Patch Set 2 : Add unit test LayerTreeHostCommonTest.StickyPositionTopScrollParent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -1 line) Patch
M cc/trees/layer_tree_host_common_unittest.cc View 1 1 chunk +74 lines, -0 lines 0 comments Download
M cc/trees/property_tree.cc View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/compositing/overflow/composited-sticky-element.html View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/compositing/overflow/composited-sticky-element-expected.html View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
flackr
Hey, This is the fix for the scroll parent case. Can you take a look? ...
4 years, 1 month ago (2016-11-10 14:18:06 UTC) #3
ajuma
On 2016/11/10 14:18:06, flackr wrote: > Hey, > > This is the fix for the ...
4 years, 1 month ago (2016-11-10 15:17:09 UTC) #4
flackr
On 2016/11/10 at 15:17:09, ajuma wrote: > On 2016/11/10 14:18:06, flackr wrote: > > Hey, ...
4 years, 1 month ago (2016-11-11 15:37:20 UTC) #6
weiliangc
LGTM
4 years, 1 month ago (2016-11-14 15:05:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486393006/20001
4 years, 1 month ago (2016-11-14 15:10:32 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_trusty_blink_rel on master.tryserver.blink (JOB_TIMED_OUT, no build URL)
4 years, 1 month ago (2016-11-14 17:12:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486393006/20001
4 years, 1 month ago (2016-11-14 18:15:55 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-14 19:22:51 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 20:09:57 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d2ae03fccb90a1de08a12be2c9d81cf4ff04f713
Cr-Commit-Position: refs/heads/master@{#431898}

Powered by Google App Engine
This is Rietveld 408576698