Non-SFI NaCl: Clean up seccomp for syscalls which return EPERM

Non-SFI NaCl: Clean up seccomp for syscalls which return EPERM

- getegid, geteuid, getgid, and getuid now return EPERM
  instead of raising SIGSYS. This simplifies the test code.
- Define a macro for sandbox tests for syscalls which return
  EPERM to reduce the size of not interesting test cases.
- Pass five zeros after syscall number to syscall() so that
  tests will not be flaky due to uninitialized values on stack.

BUG=359285
TEST=nacl_loader_unittests, trybots

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266317

[jln (very slow on Chromium), 2014-04-24 16:39:00]

lgtm

https://chromiumcodereview.appspot.com/248633004/diff/20001/components/nacl/l...
File components/nacl/loader/nonsfi/nonsfi_sandbox_unittest.cc (right):

https://chromiumcodereview.appspot.com/248633004/diff/20001/components/nacl/l...
components/nacl/loader/nonsfi/nonsfi_sandbox_unittest.cc:350: #define
RESTRICT_SYSCALL_EPERM_TEST(name)                               \
maybe align the "\"?

[Mark Seaborn, 2014-04-24 16:41:28]

LGTM

https://codereview.chromium.org/248633004/diff/20001/components/nacl/loader/n...
File components/nacl/loader/nonsfi/nonsfi_sandbox_unittest.cc (right):

https://codereview.chromium.org/248633004/diff/20001/components/nacl/loader/n...
components/nacl/loader/nonsfi/nonsfi_sandbox_unittest.cc:354: BPF_ASSERT_EQ(-1,
syscall(__NR_ ## name, 0, 0, 0, 0, 0));           \
Nit: syscalls take upto 6 args (e.g. mmap), so add an extra 0?

[hamaji, 2014-04-25 00:13:26]

https://codereview.chromium.org/248633004/diff/20001/components/nacl/loader/n...
File components/nacl/loader/nonsfi/nonsfi_sandbox_unittest.cc (right):

https://codereview.chromium.org/248633004/diff/20001/components/nacl/loader/n...
components/nacl/loader/nonsfi/nonsfi_sandbox_unittest.cc:350: #define
RESTRICT_SYSCALL_EPERM_TEST(name)                               \
On 2014/04/24 16:39:00, jln wrote:
> maybe align the "\"?

Done. Emacs seems to like this. I added a linebreak after BPF_TEST. Now the
auto-alignment of my emacs is better.

https://codereview.chromium.org/248633004/diff/20001/components/nacl/loader/n...
components/nacl/loader/nonsfi/nonsfi_sandbox_unittest.cc:354: BPF_ASSERT_EQ(-1,
syscall(__NR_ ## name, 0, 0, 0, 0, 0));           \
On 2014/04/24 16:41:29, Mark Seaborn wrote:
> Nit: syscalls take upto 6 args (e.g. mmap), so add an extra 0?

Done. I asked about this before, and this slipped from my mind :(

https://codereview.chromium.org/196793023/diff/280001/components/nacl/loader/...

I also changed the number of zeros in the similar macro for SIGSYS.

[hamaji, 2014-04-25 00:13:59]

The CQ bit was checked by hamaji@chromium.org

[commit-bot: I haz the power, 2014-04-25 00:15:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hamaji@chromium.org/248633004/40001

[commit-bot: I haz the power, 2014-04-25 01:02:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-25 01:02:39]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[hamaji, 2014-04-25 02:01:27]

The CQ bit was checked by hamaji@chromium.org

[hamaji, 2014-04-25 02:01:28]

The CQ bit was unchecked by hamaji@chromium.org

[hamaji, 2014-04-25 02:01:28]

The CQ bit was checked by hamaji@chromium.org

[commit-bot: I haz the power, 2014-04-25 02:06:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hamaji@chromium.org/248633004/40001

[commit-bot: I haz the power, 2014-04-25 02:50:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-25 02:50:25]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[hamaji, 2014-04-25 04:04:14]

The CQ bit was checked by hamaji@chromium.org

[commit-bot: I haz the power, 2014-04-25 08:23:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hamaji@chromium.org/248633004/40001

[commit-bot: I haz the power, 2014-04-26 02:09:34]

Change committed as 266317