|
|
Created:
4 years, 1 month ago by Yoshisato Yanagisawa Modified:
3 years, 11 months ago CC:
native-client-reviews_googlegroups.com, shinyak, tikuta Target Ref:
refs/heads/master Project:
nacl Visibility:
Public. |
DescriptionMake GOMA_DIR injected from env.
Also,
if NOCONTROL_GOMA environment is set, the script will not start/stop goma compiler_proxy. I am going to make goma recipe module start/stop goma compiler_proxy in the future, and the environment will be used at that time.
BUG=663630
Committed: https://chromium.googlesource.com/native_client/src/native_client/+/163dfeb43e76995b4265ecd4e78670f7dd432e44
Patch Set 1 #
Total comments: 2
Patch Set 2 : moved NOSTART_GOMA and renamed it. #Messages
Total messages: 18 (6 generated)
yyanagisawa@chromium.org changed reviewers: + bradnelson@chromium.org, ukai@chromium.org
yyanagisawa@chromium.org changed required reviewers: + bradnelson@chromium.org
lgtm https://codereview.chromium.org/2486313003/diff/1/buildbot/buildbot_pnacl_too... File buildbot/buildbot_pnacl_toolchain.py (right): https://codereview.chromium.org/2486313003/diff/1/buildbot/buildbot_pnacl_too... buildbot/buildbot_pnacl_toolchain.py:34: start_goma = not os.environ.get('NOSTART_GOMA') this will be used to let goma start/stop in caller (recipe etc) ? better to have comment or explain in CL description. maybe, after use_goma= below? control_goma = use_goma and not os.environ.get('..
Description was changed from ========== Make GOMA_DIR injected from env. BUG=663630 ========== to ========== Make GOMA_DIR injected from env. Also, if NOSTART_GOMA environment is set, the script will not start/stop goma compiler_proxy. I am going to make goma recipe module start/stop goma compiler_proxy in the future, and the environment will be used at that time. BUG=663630 ==========
Description was changed from ========== Make GOMA_DIR injected from env. Also, if NOSTART_GOMA environment is set, the script will not start/stop goma compiler_proxy. I am going to make goma recipe module start/stop goma compiler_proxy in the future, and the environment will be used at that time. BUG=663630 ========== to ========== Make GOMA_DIR injected from env. Also, if NOCONTROL_GOMA environment is set, the script will not start/stop goma compiler_proxy. I am going to make goma recipe module start/stop goma compiler_proxy in the future, and the environment will be used at that time. BUG=663630 ==========
https://codereview.chromium.org/2486313003/diff/1/buildbot/buildbot_pnacl_too... File buildbot/buildbot_pnacl_toolchain.py (right): https://codereview.chromium.org/2486313003/diff/1/buildbot/buildbot_pnacl_too... buildbot/buildbot_pnacl_toolchain.py:34: start_goma = not os.environ.get('NOSTART_GOMA') On 2016/11/10 08:01:07, ukai wrote: > this will be used to let goma start/stop in caller (recipe etc) ? > > better to have comment or explain in CL description. > > maybe, after use_goma= below? > > control_goma = use_goma and not os.environ.get('.. Done.
lgtm
The CQ bit was checked by bradnelson@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Make GOMA_DIR injected from env. Also, if NOCONTROL_GOMA environment is set, the script will not start/stop goma compiler_proxy. I am going to make goma recipe module start/stop goma compiler_proxy in the future, and the environment will be used at that time. BUG=663630 ========== to ========== Make GOMA_DIR injected from env. Also, if NOCONTROL_GOMA environment is set, the script will not start/stop goma compiler_proxy. I am going to make goma recipe module start/stop goma compiler_proxy in the future, and the environment will be used at that time. BUG=663630 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/163dfeb43... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/native_client/src/native_client/+/163dfeb43...
Message was sent while issue was closed.
On 2016/11/14 16:14:20, commit-bot: I haz the power wrote: > Committed patchset #2 (id:20001) as > https://chromium.googlesource.com/native_client/src/native_client/+/163dfeb43... This seems to have broken the PNaCl mac buildbot (e.g. https://uberchromegw.corp.google.com/i/client.nacl.toolchain/builders/mac-pna...) which has the NOCONTROL_GOMA var set (and so doesn't manually start goma) but it appears that goma is not getting started elsewhere either. Is there some other change we need to make to get this working again?
Message was sent while issue was closed.
On 2017/01/03 20:33:04, Derek Schuff wrote: > On 2016/11/14 16:14:20, commit-bot: I haz the power wrote: > > Committed patchset #2 (id:20001) as > > > https://chromium.googlesource.com/native_client/src/native_client/+/163dfeb43... > > This seems to have broken the PNaCl mac buildbot (e.g. > https://uberchromegw.corp.google.com/i/client.nacl.toolchain/builders/mac-pna...) > which has the NOCONTROL_GOMA var set (and so doesn't manually start goma) but it > appears that goma is not getting started elsewhere either. Is there some other > change we need to make to get this working again? preprocess_for_goma.start_goma step should start goma. https://uberchromegw.corp.google.com/i/client.nacl.toolchain/builders/mac-pna... https://uberchromegw.corp.google.com/i/client.nacl.toolchain/builders/mac-pna... -- Check for working CXX compiler: /b/build/slave/cache/cipd/goma/clang++ -- broken CMake Error at /b/build/slave/nacl-toolchain/build/native_client/cmake343/share/cmake-3.4/Modules/CMakeTestCXXCompiler.cmake:54 (message): The C++ compiler "/b/build/slave/cache/cipd/goma/clang++" is not able to compile a simple test program. cmake doesn't support goma well? I think checking CXX compiler should check actual compiler and cmake emits "/b/build/slave/cache/cpid/goma/gomacc /path/to/clang++" in build.ninja.
Message was sent while issue was closed.
Ah, this should be the case wrapping with goma module does not work well. compiler_proxy <-> gomacc communication does not work well in this case. We might need to set GOMA_TMP_DIR as a workaround. As Ukai-san said, I also feel using masquerade mode gomacc not good, though.
Message was sent while issue was closed.
On 2017/01/05 07:32:00, Yoshisato Yanagisawa wrote: > Ah, this should be the case wrapping with goma module does not work well. > compiler_proxy <-> gomacc communication does not work well in this case. We > might need to set GOMA_TMP_DIR as a workaround. > > As Ukai-san said, I also feel using masquerade mode gomacc not good, though. Yeah, that's a separate issue. Recent version of CMake support a flag which allows injecting a launcher like goma or ccache, e.g. -DCMAKE_C_COMPILER_LAUNCHER=/path/to/goma which is what we use for the WebAssembly waterfall. Last time I checked (a while ago), the version of CMake installed on the bots is too old and doesn't support that, so that's why the PNaCl waterfall doesn't use it. For WebAssembly the bot script manually downloads a newer CMake.
Message was sent while issue was closed.
On 2017/01/05 17:49:25, Derek Schuff wrote: > On 2017/01/05 07:32:00, Yoshisato Yanagisawa wrote: > > Ah, this should be the case wrapping with goma module does not work well. > > compiler_proxy <-> gomacc communication does not work well in this case. We > > might need to set GOMA_TMP_DIR as a workaround. > > > > As Ukai-san said, I also feel using masquerade mode gomacc not good, though. > > Yeah, that's a separate issue. Recent version of CMake support a flag which > allows injecting a launcher like goma or ccache, e.g. > -DCMAKE_C_COMPILER_LAUNCHER=/path/to/goma which is what we use for the > WebAssembly waterfall. Last time I checked (a while ago), the version of CMake > installed on the bots is too old and doesn't support that, so that's why the > PNaCl waterfall doesn't use it. For WebAssembly the bot script manually > downloads a newer CMake. I doubt it worth paying some efforts to make the script works like so but not to forget this, I have filed the issue: https://bugs.chromium.org/p/chromium/issues/detail?id=678857 |