Add keyboard explorer improvements for braille

chrome/browser/resources/chromeos/chromevox/cvox2/background/braille_command_handler.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview ChromeVox braille commands.
  */
 
 goog.provide('BrailleCommandHandler');
 
-goog.require('ChromeVoxState');
-goog.require('CommandHandler');
-
-
 goog.scope(function() {
 /**
  * Maps a dot pattern to a command.
  * @type {!Object<number, string>}
  */
 BrailleCommandHandler.DOT_PATTERN_TO_COMMAND = {
 };
 
 /**
  * Makes a dot pattern given a list of dots numbered from 1 to 8 arranged in a
  * braille cell (a 2 x 4 dot grid).
  * @param {Array<number>} dots The dots to be set in the returned pattern.
  * @return {number}
  */
 BrailleCommandHandler.makeDotPattern = function(dots) {
   return dots.reduce(function(p, c) {
     return p | (1 << c - 1);
   }, 0);
 };
 
 /**
- * Perform a braille command based on a dot pattern from a chord.
- * @param {number} dots Braille dot pattern
+ * Gets a braille command based on a dot pattern from a chord.
+ * @param {number} dots
+ * @return {string?}
  */
-BrailleCommandHandler.onBrailleCommand = function(dots) {
+BrailleCommandHandler.getCommand = function(dots) {
   var command = BrailleCommandHandler.DOT_PATTERN_TO_COMMAND[dots];
-  if (command)
-    CommandHandler.onCommand(command);
+  return command;
 };
 
 /**
+ * Gets a dot shortcut for a command.
+ * @param {string} command
+ * @param {boolean=} opt_chord True if the pattern comes from a chord.
+ * @return {string} The shortcut.
+ */
+BrailleCommandHandler.getDotShortcut = function(command, opt_chord) {
+  var commandDots = BrailleCommandHandler.getDots(command);
+  return BrailleCommandHandler.makeShortcutText(commandDots, opt_chord);
+};
+
+/**
+ * @param {number} pattern
+ * @param {boolean=} opt_chord
+ * @return {string}
+ */
+BrailleCommandHandler.makeShortcutText = function(pattern, opt_chord) {
+  var shifter = 0;
+  var dots = [];
+  while (shifter <= 7) {

[dmazzoni, 2016/11/10 01:22:04]

This might be more clear as a for loop

[David Tseng, 2016/11/10 04:56:58]

Done.

+    if ((1 << shifter) & pattern)
+    dots.push(shifter + 1);

[dmazzoni, 2016/11/10 01:22:04]

indent

[David Tseng, 2016/11/10 04:56:58]

Done.

+    shifter++;
+  }
+  var msgid;
+  if (dots.length > 1)
+    msgid = 'braille_dots';
+  else if (dots.length == 1)
+    msgid = 'braille_dot';
+
+  if (msgid) {
+    var dotText = Msgs.getMsg(msgid, [dots.join(' ')]);

[dmazzoni, 2016/11/10 01:22:04]

Would it work to join with hyphens or anything else?
Hyphens is what I see in most materials online.
But I understand if the speech feedback is bad.

[David Tseng, 2016/11/10 04:56:58]

Done.

+    if (opt_chord)
+      dotText = Msgs.getMsg('braille_chord', [dotText]);
+    return dotText;
+  }
+
+return '';

[dmazzoni, 2016/11/10 01:22:05]

indent

+};
+
+/**
+ * @param {string} command
+ * @return {number} The dot pattern for |command|.
+ */
+BrailleCommandHandler.getDots = function(command) {
+  for (var key in BrailleCommandHandler.DOT_PATTERN_TO_COMMAND) {
+    key = parseInt(key, 10);
+    if (command == BrailleCommandHandler.DOT_PATTERN_TO_COMMAND[key])
+      return key;
+  }
+  return 0;
+};
+
+/**
  * @private
  */
 BrailleCommandHandler.init_ = function() {
   var map = function(dots, command) {
     BrailleCommandHandler.DOT_PATTERN_TO_COMMAND[
       BrailleCommandHandler.makeDotPattern(dots)] = command;
   };
 
   map([2, 3], 'previousGroup');
   map([5, 6], 'nextGroup');
@@ skipping 30 matching lines @@
   map([8], 'forceClickOnCurrentItem');
   map([3, 4], 'toggleSearchWidget');
 
   // Question.
   map([1, 4, 5, 6], 'toggleKeyboardHelp');
 };
 
 BrailleCommandHandler.init_();
 
 }); //  goog.scope