Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 2486283003: MIPS: Optimize load/store with large offset (Closed)

Created:
4 years, 1 month ago by dusan.simicic
Modified:
4 years, 1 month ago
Reviewers:
ivica.bogosavljevic, v8-mips-ports, miran.karic
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Optimize load/store with large offset Currently, we are using the following sequence for load/store with large offset (offset > 16b): lui at, 0x1234 ori at, at, 0x5678 add at, s0, at lw a0, 0(at) This sequence can be optimized in the following way: lui at, 0x1234 add at, s0, at lw a0, 0x5678(at) BUG= Committed: https://crrev.com/6d054f765815e923a851f4a1ddaff3217ee57b58 Cr-Commit-Position: refs/heads/master@{#40953}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -49 lines) Patch
M src/compiler/mips/instruction-selector-mips.cc View 2 chunks +24 lines, -2 lines 0 comments Download
M src/mips/assembler-mips.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips/assembler-mips.cc View 14 chunks +63 lines, -32 lines 0 comments Download
M test/unittests/compiler/mips/instruction-selector-mips-unittest.cc View 4 chunks +10 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dusan.simicic
PTAL
4 years, 1 month ago (2016-11-10 15:51:14 UTC) #2
ivica.bogosavljevic
lgtm
4 years, 1 month ago (2016-11-14 08:43:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486283003/1
4 years, 1 month ago (2016-11-14 09:32:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 09:57:11 UTC) #6
Benedikt Meurer
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2500863003/ by bmeurer@chromium.org. ...
4 years, 1 month ago (2016-11-14 11:43:20 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:32:01 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d054f765815e923a851f4a1ddaff3217ee57b58
Cr-Commit-Position: refs/heads/master@{#40953}

Powered by Google App Engine
This is Rietveld 408576698