Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2486273002: Send mouse location as part of automation events. (Closed)

Created:
4 years, 1 month ago by dmazzoni
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, aboxhall
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Send mouse location as part of automation events. This is needed to implement select-to-speak, so that the extension gets the actual mouse location on the screen and not just the target accessibility object that's hit. BUG=593887 Committed: https://crrev.com/115283e0b6dba809a60cbcae1ef600adcda2429f Cr-Commit-Position: refs/heads/master@{#431418}

Patch Set 1 #

Patch Set 2 : Add mouseX, mouseY to automation_internal.idl too #

Patch Set 3 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M chrome/browser/ui/aura/accessibility/automation_manager_aura.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/automation.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/automation_internal.idl View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/chrome_extension_messages.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/automation_internal_custom_bindings.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/automation/automation_node.js View 3 chunks +5 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (17 generated)
dmazzoni
4 years, 1 month ago (2016-11-09 20:13:06 UTC) #4
Tom Sepez
LGTM but still got red bots.
4 years, 1 month ago (2016-11-09 21:01:34 UTC) #7
aboxhall
lgtm
4 years, 1 month ago (2016-11-10 20:56:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486273002/40001
4 years, 1 month ago (2016-11-11 00:12:19 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-11 00:39:58 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 00:42:26 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/115283e0b6dba809a60cbcae1ef600adcda2429f
Cr-Commit-Position: refs/heads/master@{#431418}

Powered by Google App Engine
This is Rietveld 408576698