Test showing crash when stepping through new Map creation.

Test showing crash when stepping through new Map creation.

Stepping through the following small program:

main() {
  var map = {};
}

will crash the vm if it is compiled in debug mode because
the debugging tries to call .Length() on an uninitialized Map.

Crash:

runtime/vm/object.h: 6545: error: expected: (value & kSmiTagMask) == kSmiTag
Dumping native stack trace for thread d12f
  [0x0000000000a66c36] dart::Profiler::DumpStackTrace(bool)
  [0x0000000000a66c36] dart::Profiler::DumpStackTrace(bool)
  [0x0000000000765548] dart::DynamicAssertionHelper::Fail(char const*, ...)
  [0x000000000074b78b] dart::Smi::ValueFromRaw(unsigned long)
  [0x000000000074b6ad] dart::Smi::Value(dart::RawSmi const*)
  [0x00000000009b92cc] dart::LinkedHashMap::Length() const
  [0x00000000009e2351] dart::LinkedHashMap::PrintJSONImpl(dart::JSONStream*, bool) const

[...]

Filed as bug https://github.com/dart-lang/sdk/issues/27790.

R=turnidge@google.com

Committed: https://github.com/dart-lang/sdk/commit/e9c78330f2c37838c78d60ebd6e1eccb0b40625f

[jensj, 2016-11-09 14:00:53]

Description was changed from

==========
Test showing crash when stepping through new Map creation.

Stepping through the following small program:

main() {
  var map = {};
}

will crash the vm if it is compiled in debug mode because
the debugging tries to call .Length() on an uninitialized Map.

Crash:

runtime/vm/object.h: 6545: error: expected: (value & kSmiTagMask) == kSmiTag
Dumping native stack trace for thread d12f
  [0x0000000000a66c36] dart::Profiler::DumpStackTrace(bool)
  [0x0000000000a66c36] dart::Profiler::DumpStackTrace(bool)
  [0x0000000000765548] dart::DynamicAssertionHelper::Fail(char const*, ...)
  [0x000000000074b78b] dart::Smi::ValueFromRaw(unsigned long)
  [0x000000000074b6ad] dart::Smi::Value(dart::RawSmi const*)
  [0x00000000009b92cc] dart::LinkedHashMap::Length() const
  [0x00000000009e2351] dart::LinkedHashMap::PrintJSONImpl(dart::JSONStream*,
bool) const

[...]
==========

to

==========
Test showing crash when stepping through new Map creation.

Stepping through the following small program:

main() {
  var map = {};
}

will crash the vm if it is compiled in debug mode because
the debugging tries to call .Length() on an uninitialized Map.

Crash:

runtime/vm/object.h: 6545: error: expected: (value & kSmiTagMask) == kSmiTag
Dumping native stack trace for thread d12f
  [0x0000000000a66c36] dart::Profiler::DumpStackTrace(bool)
  [0x0000000000a66c36] dart::Profiler::DumpStackTrace(bool)
  [0x0000000000765548] dart::DynamicAssertionHelper::Fail(char const*, ...)
  [0x000000000074b78b] dart::Smi::ValueFromRaw(unsigned long)
  [0x000000000074b6ad] dart::Smi::Value(dart::RawSmi const*)
  [0x00000000009b92cc] dart::LinkedHashMap::Length() const
  [0x00000000009e2351] dart::LinkedHashMap::PrintJSONImpl(dart::JSONStream*,
bool) const

[...]

Filed as bug https://github.com/dart-lang/sdk/issues/27790.
==========

[jensj, 2016-11-09 14:00:53]

jensj@google.com changed reviewers:
+ turnidge@google.com

[Cutch, 2016-11-09 14:48:49]

johnmccutchan@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2016-11-09 14:48:49]

Some comments.

Thanks for filing the issue.

https://codereview.chromium.org/2486213002/diff/20001/runtime/observatory/tes...
File runtime/observatory/tests/service/step_test.dart (right):

https://codereview.chromium.org/2486213002/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/service/step_test.dart:16:
isolate.vm.getEventStream(VM.kDebugStream).then((stream) {
Have you considered using helper routines from service_test_common.dart ?

https://codereview.chromium.org/2486213002/diff/20001/runtime/observatory/tes...
runtime/observatory/tests/service/step_test.dart:32:
expect(isEventOfKind(isolate.pauseEvent, ServiceEvent.kPauseStart), true);
It's possible that the isolate hasn't paused at start yet. This will likely
flake on the bots. See the helper routine `hasPausedAtStart` for a race free
version.

[jensj, 2016-11-10 08:29:20]

Thank you for your feedback!

I have refactored to use more of the helper routines from
service_test_common.dart.
If there are other helper methods I should be using (I didn't find more that
seemed applicable in service_test_common.dart) I would very much like to know
:).

[turnidge, 2016-11-14 22:42:48]

lgtm

[jensj, 2016-11-15 11:49:50]

Description was changed from

==========
Test showing crash when stepping through new Map creation.

Stepping through the following small program:

main() {
  var map = {};
}

will crash the vm if it is compiled in debug mode because
the debugging tries to call .Length() on an uninitialized Map.

Crash:

runtime/vm/object.h: 6545: error: expected: (value & kSmiTagMask) == kSmiTag
Dumping native stack trace for thread d12f
  [0x0000000000a66c36] dart::Profiler::DumpStackTrace(bool)
  [0x0000000000a66c36] dart::Profiler::DumpStackTrace(bool)
  [0x0000000000765548] dart::DynamicAssertionHelper::Fail(char const*, ...)
  [0x000000000074b78b] dart::Smi::ValueFromRaw(unsigned long)
  [0x000000000074b6ad] dart::Smi::Value(dart::RawSmi const*)
  [0x00000000009b92cc] dart::LinkedHashMap::Length() const
  [0x00000000009e2351] dart::LinkedHashMap::PrintJSONImpl(dart::JSONStream*,
bool) const

[...]

Filed as bug https://github.com/dart-lang/sdk/issues/27790.
==========

to

==========
Test showing crash when stepping through new Map creation.

Stepping through the following small program:

main() {
  var map = {};
}

will crash the vm if it is compiled in debug mode because
the debugging tries to call .Length() on an uninitialized Map.

Crash:

runtime/vm/object.h: 6545: error: expected: (value & kSmiTagMask) == kSmiTag
Dumping native stack trace for thread d12f
  [0x0000000000a66c36] dart::Profiler::DumpStackTrace(bool)
  [0x0000000000a66c36] dart::Profiler::DumpStackTrace(bool)
  [0x0000000000765548] dart::DynamicAssertionHelper::Fail(char const*, ...)
  [0x000000000074b78b] dart::Smi::ValueFromRaw(unsigned long)
  [0x000000000074b6ad] dart::Smi::Value(dart::RawSmi const*)
  [0x00000000009b92cc] dart::LinkedHashMap::Length() const
  [0x00000000009e2351] dart::LinkedHashMap::PrintJSONImpl(dart::JSONStream*,
bool) const

[...]

Filed as bug https://github.com/dart-lang/sdk/issues/27790.

R=turnidge@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e9c78330f2c37838c78d60ebd6e1eccb0b40625f
==========

[jensj, 2016-11-15 11:49:52]

Committed patchset #3 (id:40001) manually as
e9c78330f2c37838c78d60ebd6e1eccb0b40625f (presubmit successful).