[typedarrays] Remove duplicate initial map creation

[typedarrays] Remove duplicate initial map creation

Previously we created a duplicate map because we couldn't set the
correct ElementsKind when we created the function. This patch updates
the ElementsKind field of the existing map directly instead of
creating a new one.

This patch also correctly sets the instance_size when we create the
map the first time.

Committed: https://crrev.com/9e07c96fedc860873be367e5ad113f8fa0e66a9d
Cr-Commit-Position: refs/heads/master@{#40872}

[gsathya, 2016-11-10 01:20:12]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 01:20:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gsathya, 2016-11-10 01:22:26]

Description was changed from

==========
[typedarrays] Remove duplicate initial map creation

Previously we created a duplicate map because we couldn't set the
correct ElementsKind when we created the function. This patch updates
the ElementsKind field of the existing map directly instead of
creating a new one.

This patch also correctly sets the instance_size when we create the
map the first time.
==========

to

==========
[typedarrays] Remove duplicate initial map creation

Previously we created a duplicate map because we couldn't set the
correct ElementsKind when we created the function. This patch updates
the ElementsKind field of the existing map directly instead of
creating a new one.

This patch also correctly sets the instance_size when we create the
map the first time.
==========

[gsathya, 2016-11-10 01:22:26]

gsathya@chromium.org changed reviewers:
+ adamk@chromium.org

[gsathya, 2016-11-10 01:26:18]

Instead of directly setting elements_kind(), I could create a new
InstallFunction and factory->NewFunction that take in a elements_kind and use it
while creating the function. Currently NewFunction just checks for JS_ARRAY_TYPE
and switches between FAST_SMI_ELEMENTS and FAST_HOLEY_SMI_ELEMENTS for
elements_kind while creating the function.

WDYT?

[adamk, 2016-11-10 01:35:21]

The set_elements_kind call you have seems OK to me.

lgtm and thanks for the cleanup!

[commit-bot: I haz the power, 2016-11-10 01:46:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 01:46:57]

Dry run: This issue passed the CQ dry run.

[gsathya, 2016-11-10 01:47:23]

The CQ bit was checked by gsathya@chromium.org

[commit-bot: I haz the power, 2016-11-10 01:47:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 01:49:28]

Description was changed from

==========
[typedarrays] Remove duplicate initial map creation

Previously we created a duplicate map because we couldn't set the
correct ElementsKind when we created the function. This patch updates
the ElementsKind field of the existing map directly instead of
creating a new one.

This patch also correctly sets the instance_size when we create the
map the first time.
==========

to

==========
[typedarrays] Remove duplicate initial map creation

Previously we created a duplicate map because we couldn't set the
correct ElementsKind when we created the function. This patch updates
the ElementsKind field of the existing map directly instead of
creating a new one.

This patch also correctly sets the instance_size when we create the
map the first time.
==========

[commit-bot: I haz the power, 2016-11-10 01:49:29]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-17 22:28:04]

Description was changed from

==========
[typedarrays] Remove duplicate initial map creation

Previously we created a duplicate map because we couldn't set the
correct ElementsKind when we created the function. This patch updates
the ElementsKind field of the existing map directly instead of
creating a new one.

This patch also correctly sets the instance_size when we create the
map the first time.
==========

to

==========
[typedarrays] Remove duplicate initial map creation

Previously we created a duplicate map because we couldn't set the
correct ElementsKind when we created the function. This patch updates
the ElementsKind field of the existing map directly instead of
creating a new one.

This patch also correctly sets the instance_size when we create the
map the first time.

Committed: https://crrev.com/9e07c96fedc860873be367e5ad113f8fa0e66a9d
Cr-Commit-Position: refs/heads/master@{#40872}
==========

[commit-bot: I haz the power, 2016-11-17 22:28:05]

Patchset 1 (id:??) landed as
https://crrev.com/9e07c96fedc860873be367e5ad113f8fa0e66a9d
Cr-Commit-Position: refs/heads/master@{#40872}