[wasm] Fix bounds check in LoadDataSegments.

[wasm] Fix bounds check in LoadDataSegments.

The bounds check in LoadDataSegment was off by one. I also improved the
error message, and fixed an issue where data was initialized even if
the bounds check failed.

In InstantiateModuleForTesting I allow instantiation of modules without
exports. This check was legacy code from the time where instantiation
and execution was still combined in a single function.

R=titzer@chromium.org, rossberg@chromium.org
TEST=cctest/test-run-wasm-module/InitDataAtTheUpperLimit

Committed: https://crrev.com/ac183d492f12b5e4f4c2b25388647bc34aa85c75
Cr-Commit-Position: refs/heads/master@{#40856}

[ahaas, 2016-11-09 10:47:18]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 10:47:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2016-11-09 10:51:33]

On 2016/11/09 10:47:16, ahaas wrote:

lgtm

[commit-bot: I haz the power, 2016-11-09 11:13:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 11:13:58]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-11-09 11:36:31]

The CQ bit was checked by ahaas@chromium.org

[commit-bot: I haz the power, 2016-11-09 11:36:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 11:38:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-17 22:27:16]

Description was changed from

==========
[wasm] Fix bounds check in LoadDataSegments.

The bounds check in LoadDataSegment was off by one. I also improved the
error message, and fixed an issue where data was initialized even if
the bounds check failed.

In InstantiateModuleForTesting I allow instantiation of modules without
exports. This check was legacy code from the time where instantiation
and execution was still combined in a single function.

R=titzer@chromium.org, rossberg@chromium.org
TEST=cctest/test-run-wasm-module/InitDataAtTheUpperLimit
==========

to

==========
[wasm] Fix bounds check in LoadDataSegments.

The bounds check in LoadDataSegment was off by one. I also improved the
error message, and fixed an issue where data was initialized even if
the bounds check failed.

In InstantiateModuleForTesting I allow instantiation of modules without
exports. This check was legacy code from the time where instantiation
and execution was still combined in a single function.

R=titzer@chromium.org, rossberg@chromium.org
TEST=cctest/test-run-wasm-module/InitDataAtTheUpperLimit

Committed: https://crrev.com/ac183d492f12b5e4f4c2b25388647bc34aa85c75
Cr-Commit-Position: refs/heads/master@{#40856}
==========

[commit-bot: I haz the power, 2016-11-17 22:27:18]

Patchset 1 (id:??) landed as
https://crrev.com/ac183d492f12b5e4f4c2b25388647bc34aa85c75
Cr-Commit-Position: refs/heads/master@{#40856}