Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: include/v8.h

Issue 2486173002: [api] Remove marking persistents as partially dependent (Closed)
Patch Set: Addressed comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/flag-definitions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 7db8ee7937fef605088611029bb7245a5675e55a..3e61950b1e2a6fcf7cd263795e8c14fdb83a2bac 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -574,18 +574,6 @@ template <class T> class PersistentBase {
V8_INLINE void MarkIndependent();
/**
- * Marks the reference to this object partially dependent. Partially dependent
- * handles only depend on other partially dependent handles and these
- * dependencies are provided through object groups. It provides a way to build
- * smaller object groups for young objects that represent only a subset of all
- * external dependencies. This mark is automatically cleared after each
- * garbage collection.
- */
- V8_INLINE V8_DEPRECATED(
- "deprecated optimization, do not use partially dependent groups",
- void MarkPartiallyDependent());
-
- /**
* Marks the reference to this object as active. The scavenge garbage
* collection should not reclaim the objects marked as active.
* This bit is cleared after the each garbage collection pass.
@@ -8326,7 +8314,6 @@ class Internals {
static const int kNodeStateIsPendingValue = 3;
static const int kNodeStateIsNearDeathValue = 4;
static const int kNodeIsIndependentShift = 3;
- static const int kNodeIsPartiallyDependentShift = 4;
static const int kNodeIsActiveShift = 4;
static const int kJSObjectType = 0xbc;
@@ -8622,17 +8609,6 @@ void PersistentBase<T>::MarkIndependent() {
I::kNodeIsIndependentShift);
}
-
-template <class T>
-void PersistentBase<T>::MarkPartiallyDependent() {
- typedef internal::Internals I;
- if (this->IsEmpty()) return;
- I::UpdateNodeFlag(reinterpret_cast<internal::Object**>(this->val_),
- true,
- I::kNodeIsPartiallyDependentShift);
-}
-
-
template <class T>
void PersistentBase<T>::MarkActive() {
typedef internal::Internals I;
« no previous file with comments | « no previous file | src/flag-definitions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698