[api] Remove marking persistents as partially dependent

[api] Remove marking persistents as partially dependent

Also remove the flag scavenge_reclaim_unmodified_objects which has been
defaulted to true for quite some time now.

BUG=chromium:651354
Committed: https://crrev.com/58a753053c5ebacec3c603c084b5b4a94799583a
Cr-Commit-Position: refs/heads/master@{#40878}

[Michael Lippautz, 2016-11-09 10:44:11]

Description was changed from

==========
[api] Remove marking persistents as partially dependent

Also remove the flag scavenge_reclaim_unmodified_objects which has been
defaulted to true for quite some time now.

BUG=
==========

to

==========
[api] Remove marking persistents as partially dependent

Also remove the flag scavenge_reclaim_unmodified_objects which has been
defaulted to true for quite some time now.

BUG=chromium:651354
==========

[Michael Lippautz, 2016-11-09 10:44:12]

mlippautz@chromium.org changed reviewers:
+ jochen@chromium.org

[Michael Lippautz, 2016-11-09 10:45:08]

Can we remove this? The api has been deprecated for quite a while and the flag
defaulted to true since May. I would like to avoid porting this to a new young
generation MC.

[Michael Lippautz, 2016-11-09 10:48:20]

Forgot to mention: No callers from chromium.

[Michael Lippautz, 2016-11-09 10:50:46]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 10:50:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 10:52:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 10:52:21]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/15863)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/15901)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/15825)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/28123)

[Michael Lippautz, 2016-11-09 11:01:48]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 11:02:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 11:05:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 11:05:08]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/15864)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/12161)

[Michael Lippautz, 2016-11-09 11:30:30]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 11:30:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 11:57:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 11:57:16]

Dry run: This issue passed the CQ dry run.

[ulan, 2016-11-09 12:24:27]

ulan@chromium.org changed reviewers:
+ ulan@chromium.org

[ulan, 2016-11-09 12:24:28]

dbc lgtm

https://codereview.chromium.org/2486173002/diff/60001/src/global-handles.cc
File src/global-handles.cc (right):

https://codereview.chromium.org/2486173002/diff/60001/src/global-handles.cc#n...
src/global-handles.cc:671: if ((node->is_independent()) && node->IsWeak() &&
Nit: redundant ()

https://codereview.chromium.org/2486173002/diff/60001/src/global-handles.cc#n...
src/global-handles.cc:683: if ((node->is_independent()) &&
node->IsWeakRetainer()) {
Nit: redundant ()

[Michael Lippautz, 2016-11-09 14:06:47]

https://codereview.chromium.org/2486173002/diff/60001/src/global-handles.cc
File src/global-handles.cc (right):

https://codereview.chromium.org/2486173002/diff/60001/src/global-handles.cc#n...
src/global-handles.cc:671: if ((node->is_independent()) && node->IsWeak() &&
On 2016/11/09 12:24:28, ulan wrote:
> Nit: redundant ()

Done.

https://codereview.chromium.org/2486173002/diff/60001/src/global-handles.cc#n...
src/global-handles.cc:683: if ((node->is_independent()) &&
node->IsWeakRetainer()) {
On 2016/11/09 12:24:28, ulan wrote:
> Nit: redundant ()

Done.

[Michael Lippautz, 2016-11-09 14:06:51]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 14:07:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 14:35:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 14:35:52]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2016-11-10 09:27:01]

Jochen: Please let me know if you disagree on this one. Landing for now.

[Michael Lippautz, 2016-11-10 09:27:07]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2016-11-10 09:27:08]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/2486173002/#ps80001
(title: "Addressed comments")

[commit-bot: I haz the power, 2016-11-10 09:27:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 09:29:13]

Description was changed from

==========
[api] Remove marking persistents as partially dependent

Also remove the flag scavenge_reclaim_unmodified_objects which has been
defaulted to true for quite some time now.

BUG=chromium:651354
==========

to

==========
[api] Remove marking persistents as partially dependent

Also remove the flag scavenge_reclaim_unmodified_objects which has been
defaulted to true for quite some time now.

BUG=chromium:651354
==========

[commit-bot: I haz the power, 2016-11-10 09:29:14]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-17 22:28:21]

Description was changed from

==========
[api] Remove marking persistents as partially dependent

Also remove the flag scavenge_reclaim_unmodified_objects which has been
defaulted to true for quite some time now.

BUG=chromium:651354
==========

to

==========
[api] Remove marking persistents as partially dependent

Also remove the flag scavenge_reclaim_unmodified_objects which has been
defaulted to true for quite some time now.

BUG=chromium:651354

Committed: https://crrev.com/58a753053c5ebacec3c603c084b5b4a94799583a
Cr-Commit-Position: refs/heads/master@{#40878}
==========

[commit-bot: I haz the power, 2016-11-17 22:28:23]

Patchset 5 (id:??) landed as
https://crrev.com/58a753053c5ebacec3c603c084b5b4a94799583a
Cr-Commit-Position: refs/heads/master@{#40878}