Add a flag to disable the check if proxy is core data saver proxy

Add a flag to disable the check if proxy is core data saver proxy

This CL adds a flag that disables the check if proxy is a core data
saver proxy. This flag would be later used in tests in conjunction
with setting the data saver proxy to an XT proxy to verify QUIC +
data saver communication with an XT proxy.

BUG=663584
Committed: https://crrev.com/afa3ca6074fff2cc203eabf41fafc642cd9a8dc0
Cr-Commit-Position: refs/heads/master@{#431047}

[tbansal1, 2016-11-09 01:06:14]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 01:07:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2016-11-09 01:07:24]

Description was changed from

==========
Add a flag to disable the check if proxy is core data saver proxy

BUG=663584
==========

to

==========
Add a flag to disable the check if proxy is core data saver proxy

This CL adds a flag that disables the check if proxy is a core data
saver proxy. This flag would be later used in tests in conjunction
with setting the data saver proxy to an XT proxy to verify QUIC +
data saver communication with an XT proxy.

BUG=663584
==========

[tbansal1, 2016-11-09 01:07:41]

tbansal@chromium.org changed reviewers:
+ ryansturm@chromium.org

[tbansal1, 2016-11-09 01:07:41]

ryansturm: ptal. thanks.

[commit-bot: I haz the power, 2016-11-09 01:53:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 01:53:40]

Dry run: This issue passed the CQ dry run.

[RyanSturm, 2016-11-09 17:41:27]

lgtm % nit

https://codereview.chromium.org/2486093002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc
(right):

https://codereview.chromium.org/2486093002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc:95:
"data-reduction-proxy-disable-quic-core-proxy-check";
Can you change this to less negative?
"data-reduction-proxy-enable-quic-on-non-core-proxies" is pretty wordy, but
IIUC, it is accurate and less confusing.

[tbansal1, 2016-11-09 21:00:59]

https://codereview.chromium.org/2486093002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc
(right):

https://codereview.chromium.org/2486093002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc:95:
"data-reduction-proxy-disable-quic-core-proxy-check";
On 2016/11/09 17:41:27, Ryan Sturm wrote:
> Can you change this to less negative?
> "data-reduction-proxy-enable-quic-on-non-core-proxies" is pretty wordy, but
> IIUC, it is accurate and less confusing.

Done.

[tbansal1, 2016-11-09 21:01:01]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 21:01:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 21:47:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 21:47:03]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2016-11-09 22:02:17]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2016-11-09 22:02:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
ryansturm@chromium.org
Link to the patchset: https://codereview.chromium.org/2486093002/#ps20001
(title: "ps")

[commit-bot: I haz the power, 2016-11-09 22:03:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 22:08:48]

Description was changed from

==========
Add a flag to disable the check if proxy is core data saver proxy

This CL adds a flag that disables the check if proxy is a core data
saver proxy. This flag would be later used in tests in conjunction
with setting the data saver proxy to an XT proxy to verify QUIC +
data saver communication with an XT proxy.

BUG=663584
==========

to

==========
Add a flag to disable the check if proxy is core data saver proxy

This CL adds a flag that disables the check if proxy is a core data
saver proxy. This flag would be later used in tests in conjunction
with setting the data saver proxy to an XT proxy to verify QUIC +
data saver communication with an XT proxy.

BUG=663584
==========

[commit-bot: I haz the power, 2016-11-09 22:08:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-09 22:16:16]

Description was changed from

==========
Add a flag to disable the check if proxy is core data saver proxy

This CL adds a flag that disables the check if proxy is a core data
saver proxy. This flag would be later used in tests in conjunction
with setting the data saver proxy to an XT proxy to verify QUIC +
data saver communication with an XT proxy.

BUG=663584
==========

to

==========
Add a flag to disable the check if proxy is core data saver proxy

This CL adds a flag that disables the check if proxy is a core data
saver proxy. This flag would be later used in tests in conjunction
with setting the data saver proxy to an XT proxy to verify QUIC +
data saver communication with an XT proxy.

BUG=663584

Committed: https://crrev.com/afa3ca6074fff2cc203eabf41fafc642cd9a8dc0
Cr-Commit-Position: refs/heads/master@{#431047}
==========

[commit-bot: I haz the power, 2016-11-09 22:16:17]

Patchset 2 (id:??) landed as
https://crrev.com/afa3ca6074fff2cc203eabf41fafc642cd9a8dc0
Cr-Commit-Position: refs/heads/master@{#431047}