Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: services/service_manager/tests/lifecycle/app_client.cc

Issue 2486073003: Revert of Service Manager: Implement graceful service termination (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/service_manager/tests/lifecycle/app_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/service_manager/tests/lifecycle/app_client.cc
diff --git a/services/service_manager/tests/lifecycle/app_client.cc b/services/service_manager/tests/lifecycle/app_client.cc
index 905260cf55fbc39775d0e8ae2d23ccd10d550d34..71d7c413ae230441adf7bda6cf2109892bb54a75 100644
--- a/services/service_manager/tests/lifecycle/app_client.cc
+++ b/services/service_manager/tests/lifecycle/app_client.cc
@@ -25,11 +25,6 @@
return true;
}
-bool AppClient::OnStop() {
- base::MessageLoop::current()->QuitWhenIdle();
- return true;
-}
-
void AppClient::Create(const Identity& remote_identity,
mojom::LifecycleControlRequest request) {
bindings_.AddBinding(this, std::move(request));
@@ -40,7 +35,7 @@
}
void AppClient::GracefulQuit() {
- context_->RequestQuit();
+ base::MessageLoop::current()->QuitWhenIdle();
}
void AppClient::Crash() {
@@ -58,7 +53,7 @@
void AppClient::BindingLost() {
if (bindings_.empty())
- OnStop();
+ GracefulQuit();
}
} // namespace test
« no previous file with comments | « services/service_manager/tests/lifecycle/app_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698