Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2486073003: Revert of Service Manager: Implement graceful service termination (Closed)

Created:
4 years, 1 month ago by benwells
Modified:
4 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Service Manager: Implement graceful service termination (patchset #1 id:1 of https://codereview.chromium.org/2480603004/ ) Reason for revert: Seems to be the cause of lock order inversions on TSan bots. See https://crbug.com/663557 for details. BUG=663557 Original issue's description: > Service Manager: Implement graceful service termination > > Adds a new ServiceControl client interface associated with > a service's Service interface. This allows a service to notify > the Service Manager that it's ready to be terminated by calling > RequestQuit(). > > Adds an ack reply to Service.OnConnect. The Service Manager will > ignore any RequestQuit() issued while an OnConnect is still > pending acknowledgement. > > Fixes a race in existing service_manager_unittests which was > causing > some tests to hang fairly regularly, using RequestQuit() > to avoid races between service shutdown and incoming connections. > > Also fixes incorrect base::SimpleThread usage in some tests. > > BUG=654986, 662177 > > Committed: https://crrev.com/5b9cb3df6c06015d79aeb688c2b8905016086b9e > Cr-Commit-Position: refs/heads/master@{#430414} TBR=ben@chromium.org,tsepez@chromium.org,blundell@chromium.org,rockot@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=654986, 662177 Committed: https://crrev.com/1a665b53fe46aba0c80416b9b354760fc1ccf749 Cr-Commit-Position: refs/heads/master@{#430868}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -144 lines) Patch
M chrome/test/base/mojo_test_connector.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M services/service_manager/public/cpp/lib/service_context.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M services/service_manager/public/cpp/service_context.h View 3 chunks +1 line, -7 lines 0 comments Download
M services/service_manager/public/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/service_manager/public/interfaces/service.mojom View 4 chunks +3 lines, -9 lines 0 comments Download
D services/service_manager/public/interfaces/service_control.mojom View 1 chunk +0 lines, -16 lines 0 comments Download
M services/service_manager/service_manager.cc View 10 chunks +4 lines, -32 lines 0 comments Download
M services/service_manager/tests/connect/connect_test_package.cc View 8 chunks +27 lines, -62 lines 0 comments Download
M services/service_manager/tests/lifecycle/app_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/service_manager/tests/lifecycle/app_client.cc View 3 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
benwells
Created Revert of Service Manager: Implement graceful service termination
4 years, 1 month ago (2016-11-09 03:45:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486073003/1
4 years, 1 month ago (2016-11-09 03:45:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 05:05:08 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 05:09:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a665b53fe46aba0c80416b9b354760fc1ccf749
Cr-Commit-Position: refs/heads/master@{#430868}

Powered by Google App Engine
This is Rietveld 408576698