Chromium Code Reviews
DescriptionRevert of Service Manager: Implement graceful service termination (patchset #1 id:1 of https://codereview.chromium.org/2480603004/ )
Reason for revert:
Seems to be the cause of lock order inversions on TSan bots.
See https://crbug.com/663557 for details.
BUG=663557
Original issue's description:
> Service Manager: Implement graceful service termination
>
> Adds a new ServiceControl client interface associated with
> a service's Service interface. This allows a service to notify
> the Service Manager that it's ready to be terminated by calling
> RequestQuit().
>
> Adds an ack reply to Service.OnConnect. The Service Manager will
> ignore any RequestQuit() issued while an OnConnect is still
> pending acknowledgement.
>
> Fixes a race in existing service_manager_unittests which was
> causing
> some tests to hang fairly regularly, using RequestQuit()
> to avoid races between service shutdown and incoming connections.
>
> Also fixes incorrect base::SimpleThread usage in some tests.
>
> BUG=654986, 662177
>
> Committed: https://crrev.com/5b9cb3df6c06015d79aeb688c2b8905016086b9e
> Cr-Commit-Position: refs/heads/master@{#430414}
TBR=ben@chromium.org,tsepez@chromium.org,blundell@chromium.org,rockot@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=654986, 662177
Committed: https://crrev.com/1a665b53fe46aba0c80416b9b354760fc1ccf749
Cr-Commit-Position: refs/heads/master@{#430868}
Patch Set 1 #Messages
Total messages: 7 (3 generated)
|