Buildbot json for swarming Mac 10.10 Perf on perf waterfall

Buildbot json for swarming Mac 10.10 Perf on perf waterfall

BUG=chromium:663372
Committed: https://crrev.com/318b650cb0192db5c20dc0cb709f4f50b1ba8a93
Cr-Commit-Position: refs/heads/master@{#431148}

[eyaich1, 2016-11-09 19:51:43]

The CQ bit was checked by eyaich@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 19:52:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eyaich1, 2016-11-09 20:35:25]

eyaich@chromium.org changed reviewers:
+ dtu@chromium.org, stip@chromium.org

[commit-bot: I haz the power, 2016-11-09 20:45:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 20:45:15]

Dry run: This issue passed the CQ dry run.

[dtu, 2016-11-09 20:53:39]

lgtm

[ghost stip (do not use), 2016-11-09 21:28:34]

lgtm

https://codereview.chromium.org/2486063003/diff/1/tools/perf/generate_perf_js...
File tools/perf/generate_perf_json.py (right):

https://codereview.chromium.org/2486063003/diff/1/tools/perf/generate_perf_js...
tools/perf/generate_perf_json.py:463: if dimension.get('gpu', None):
nit: the none is implicit, you can just do dimension.get('gpu')

[dtu, 2016-11-09 23:43:11]

https://codereview.chromium.org/2486063003/diff/1/tools/perf/generate_perf_js...
File tools/perf/generate_perf_json.py (right):

https://codereview.chromium.org/2486063003/diff/1/tools/perf/generate_perf_js...
tools/perf/generate_perf_json.py:463: if dimension.get('gpu', None):
On 2016/11/09 21:28:34, stip wrote:
> nit: the none is implicit, you can just do dimension.get('gpu')

I think the most Pythonic way is
if 'gpu' in dimension:

[eyaich1, 2016-11-10 00:22:47]

https://codereview.chromium.org/2486063003/diff/1/tools/perf/generate_perf_js...
File tools/perf/generate_perf_json.py (right):

https://codereview.chromium.org/2486063003/diff/1/tools/perf/generate_perf_js...
tools/perf/generate_perf_json.py:463: if dimension.get('gpu', None):
On 2016/11/09 23:43:11, dtu wrote:
> On 2016/11/09 21:28:34, stip wrote:
> > nit: the none is implicit, you can just do dimension.get('gpu')
> 
> I think the most Pythonic way is
> if 'gpu' in dimension:

Done.

https://codereview.chromium.org/2486063003/diff/1/tools/perf/generate_perf_js...
tools/perf/generate_perf_json.py:463: if dimension.get('gpu', None):
On 2016/11/09 21:28:34, stip wrote:
> nit: the none is implicit, you can just do dimension.get('gpu')

Done.

[eyaich1, 2016-11-10 01:23:44]

The CQ bit was checked by eyaich@chromium.org

[eyaich1, 2016-11-10 01:23:44]

The patchset sent to the CQ was uploaded after l-g-t-m from dtu@chromium.org,
stip@chromium.org
Link to the patchset: https://codereview.chromium.org/2486063003/#ps20001
(title: "Responding to review comments")

[commit-bot: I haz the power, 2016-11-10 01:24:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 02:33:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-10 02:42:01]

Description was changed from

==========
Buildbot json for swarming Mac 10.10 Perf on perf waterfall

BUG=chromium:663372
==========

to

==========
Buildbot json for swarming Mac 10.10 Perf on perf waterfall

BUG=chromium:663372

Committed: https://crrev.com/318b650cb0192db5c20dc0cb709f4f50b1ba8a93
Cr-Commit-Position: refs/heads/master@{#431148}
==========

[commit-bot: I haz the power, 2016-11-10 02:42:02]

Patchset 2 (id:??) landed as
https://crrev.com/318b650cb0192db5c20dc0cb709f4f50b1ba8a93
Cr-Commit-Position: refs/heads/master@{#431148}