Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Unified Diff: runtime/vm/kernel_reader.h

Issue 2485993002: VM: Support bootstrapping core libraries from Kernel binaries instead of source. (Closed)
Patch Set: Done Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/kernel_reader.h
diff --git a/runtime/vm/kernel_reader.h b/runtime/vm/kernel_reader.h
index e6d9e55e949428af5543b4484b36d813d584eaf2..79315abaef28bbaf3090beefda67dedfbdad808c 100644
--- a/runtime/vm/kernel_reader.h
+++ b/runtime/vm/kernel_reader.h
@@ -23,8 +23,6 @@ class BuildingTranslationHelper : public TranslationHelper {
: TranslationHelper(thread, zone, isolate), reader_(reader) {}
virtual ~BuildingTranslationHelper() {}
- virtual void SetFinalize(bool finalize);
-
virtual RawLibrary* LookupLibraryByKernelLibrary(Library* library);
virtual RawClass* LookupClassByKernelClass(Class* klass);
@@ -58,9 +56,10 @@ class KernelReader {
zone_(thread_->zone()),
isolate_(thread_->isolate()),
translation_helper_(this, thread_, zone_, isolate_),
- type_translator_(&translation_helper_, &active_class_, !bootstrapping),
+ type_translator_(&translation_helper_,
+ &active_class_,
+ /*finalize=*/false),
bootstrapping_(bootstrapping),
- finalize_(!bootstrapping),
buffer_(buffer),
buffer_length_(len) {}
@@ -80,7 +79,7 @@ class KernelReader {
friend class BuildingTranslationHelper;
void ReadPreliminaryClass(dart::Class* klass, Class* kernel_klass);
- void ReadClass(const dart::Library& library, Class* kernel_klass);
+ dart::Class& ReadClass(const dart::Library& library, Class* kernel_klass);
void ReadProcedure(const dart::Library& library, const dart::Class& owner,
Procedure* procedure, Class* kernel_klass = NULL);
@@ -104,9 +103,6 @@ class KernelReader {
bool bootstrapping_;
- // Should created classes be finalized when they are created?
- bool finalize_;
-
const uint8_t* buffer_;
intptr_t buffer_length_;

Powered by Google App Engine
This is Rietveld 408576698