Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2485983002:
[TTS] Fix Translation by whitelisting CS mojo services. (Closed)
|
Created:
4 years, 1 month ago by Donn Denman Modified:
4 years, 1 month ago CC:
chromium-reviews, mdjones, Theresa, Ben Goodger (Google) Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[TTS] Fix Translation by whitelisting CS mojo services.
Mojo services were recently whitelisted, which broke Contextual Search's usage
for translation and quick answers.
This CL adds Contextual Search to the content browser and content renderer
mojo manifests in order to make them part of the whitelist.
BUG=662219, 661118
Committed: https://crrev.com/353fa4026777357872b64b66bb976f9d316e2c6d
Cr-Commit-Position: refs/heads/master@{#432064}
Patch Set 1 #
Messages
Total messages: 25 (11 generated)
donnd@chromium.org changed reviewers: + jochen@chromium.org
jochen@, PTAL. Thanks!
Description was changed from ========== [TTS] Fix Translation by whitelisting CS mojo services. Mojo services were recently whitelisted, which broke Contextual Search's usage for translation and quick answers. This CL adds Contextual Search to the content browser and content renderer mojo manifests in order to make them part of the whitelist. BUG=662219,661118 ========== to ========== [TTS] Fix Translation by whitelisting CS mojo services. Mojo services were recently whitelisted, which broke Contextual Search's usage for translation and quick answers. This CL adds Contextual Search to the content browser and content renderer mojo manifests in order to make them part of the whitelist. BUG=662219,661118 ==========
donnd@chromium.org changed reviewers: + nasko@chromium.org - jochen@chromium.org
Nasko, PTAL. Thanks in advance!
I'm not a chrome/ OWNER and honestly don't know much about this area. Please divert to one of the owners closer to that code.
donnd@chromium.org changed reviewers: + ben@chromium.org - nasko@chromium.org
Ben, PTAL. Thanks!
donnd@chromium.org changed reviewers: + tsepez@chromium.org - ben@chromium.org
Tom, PTAL. Ben, removed you from the reviewer list since I needed broader OWNERs coverage, sorry for the bother.
LGTM
The CQ bit was checked by donnd@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
donnd@chromium.org changed reviewers: + ben@chromium.org - tsepez@chromium.org
Ben, PTAL. Looks like I do need your OWNERS approval after all.
Ben, PTAL. Thanks!
lgtm
The CQ bit was checked by donnd@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [TTS] Fix Translation by whitelisting CS mojo services. Mojo services were recently whitelisted, which broke Contextual Search's usage for translation and quick answers. This CL adds Contextual Search to the content browser and content renderer mojo manifests in order to make them part of the whitelist. BUG=662219,661118 ========== to ========== [TTS] Fix Translation by whitelisting CS mojo services. Mojo services were recently whitelisted, which broke Contextual Search's usage for translation and quick answers. This CL adds Contextual Search to the content browser and content renderer mojo manifests in order to make them part of the whitelist. BUG=662219,661118 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [TTS] Fix Translation by whitelisting CS mojo services. Mojo services were recently whitelisted, which broke Contextual Search's usage for translation and quick answers. This CL adds Contextual Search to the content browser and content renderer mojo manifests in order to make them part of the whitelist. BUG=662219,661118 ========== to ========== [TTS] Fix Translation by whitelisting CS mojo services. Mojo services were recently whitelisted, which broke Contextual Search's usage for translation and quick answers. This CL adds Contextual Search to the content browser and content renderer mojo manifests in order to make them part of the whitelist. BUG=662219,661118 Committed: https://crrev.com/353fa4026777357872b64b66bb976f9d316e2c6d Cr-Commit-Position: refs/heads/master@{#432064} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/353fa4026777357872b64b66bb976f9d316e2c6d Cr-Commit-Position: refs/heads/master@{#432064} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
