Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 248593002: [DirectWrite] Force subpixel font sizing to on when DW is enabled (Closed)

Created:
6 years, 8 months ago by eae
Modified:
6 years, 7 months ago
Reviewers:
cpu_(ooo_6.6-7.5), jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[DirectWrite] Force subpixel font sizing to on when DW is enabled Force subpixel font sizing to be enabled when direct write is enabled using the --enable-direct-write command line switch. This used to be the case but broke when sandbox support was added. BUG=25541 R=cpu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268879

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/renderer/renderer_main_platform_delegate_win.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
eae
6 years, 7 months ago (2014-05-06 01:36:58 UTC) #1
eae
On 2014/05/06 01:36:58, eae wrote:
6 years, 7 months ago (2014-05-06 15:45:31 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm thanks for the quick turarround.
6 years, 7 months ago (2014-05-06 19:50:58 UTC) #3
eae
The CQ bit was checked by eae@chromium.org
6 years, 7 months ago (2014-05-06 19:51:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/248593002/1
6 years, 7 months ago (2014-05-06 19:53:13 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-07 01:56:13 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #2). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-07 08:00:25 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-07 08:05:32 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-05-07 08:05:32 UTC) #9
eae
The CQ bit was checked by eae@chromium.org
6 years, 7 months ago (2014-05-07 16:38:47 UTC) #10
eae
The CQ bit was unchecked by eae@chromium.org
6 years, 7 months ago (2014-05-07 16:39:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/248593002/1
6 years, 7 months ago (2014-05-07 16:39:20 UTC) #12
eae
+ jam Need approval for content/
6 years, 7 months ago (2014-05-07 16:39:44 UTC) #13
jam
lgtm
6 years, 7 months ago (2014-05-07 18:03:10 UTC) #14
eae
Thanks John!
6 years, 7 months ago (2014-05-07 18:17:32 UTC) #15
eae
The CQ bit was checked by eae@chromium.org
6 years, 7 months ago (2014-05-07 18:17:34 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/248593002/1
6 years, 7 months ago (2014-05-07 18:21:43 UTC) #17
commit-bot: I haz the power
6 years, 7 months ago (2014-05-07 18:47:49 UTC) #18
Message was sent while issue was closed.
Change committed as 268879

Powered by Google App Engine
This is Rietveld 408576698