Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2485853003: Include 'enableGenericMethods' into salt. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 1 month ago (2016-11-08 20:52:26 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2485853003/diff/1/pkg/analyzer/lib/src/dart/analysis/driver.dart File pkg/analyzer/lib/src/dart/analysis/driver.dart (right): https://codereview.chromium.org/2485853003/diff/1/pkg/analyzer/lib/src/dart/analysis/driver.dart#newcode634 pkg/analyzer/lib/src/dart/analysis/driver.dart:634: analysisOptionsSalt |= _analysisOptions.enableGenericMethods ? (1 << 1) : ...
4 years, 1 month ago (2016-11-08 21:15:08 UTC) #2
scheglov
https://codereview.chromium.org/2485853003/diff/1/pkg/analyzer/lib/src/dart/analysis/driver.dart File pkg/analyzer/lib/src/dart/analysis/driver.dart (right): https://codereview.chromium.org/2485853003/diff/1/pkg/analyzer/lib/src/dart/analysis/driver.dart#newcode634 pkg/analyzer/lib/src/dart/analysis/driver.dart:634: analysisOptionsSalt |= _analysisOptions.enableGenericMethods ? (1 << 1) : 0; ...
4 years, 1 month ago (2016-11-09 01:21:38 UTC) #3
scheglov
4 years, 1 month ago (2016-11-09 01:24:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0f52c15f1c335cc606af2d663033b5c745e7672b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698