[Sync] Ensure unready types' state is updated before every reconfiguration

[Sync] Ensure unready types' state is updated before every reconfiguration

Problematic scenario involves one unready datatype:
- Perform normal configuration.
- Call ResetDataTypeErrors()
- Trigger reconfiguration through failure of some other datatype.
In this scenario DataTypeStatusTable::unready_errors_ is empty and
ModelAssociationManager attempts to call LoadModels for unready type.

In this change I move code to update unready_errors_ so it gets executed in
reconfiguration codepath as well as normal configure.

R=zea@chromium.org
BUG=661817
Committed: https://crrev.com/f09651efa84e17b879e82400422f4cfa87738ac3
Cr-Commit-Position: refs/heads/master@{#430843}

[pavely, 2016-11-08 23:28:59]

The CQ bit was checked by pavely@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 23:29:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nicolas Zea, 2016-11-09 00:38:22]

lgtm

https://codereview.chromium.org/2485773003/diff/1/components/sync/driver/data...
File components/sync/driver/data_type_manager_impl.cc (right):

https://codereview.chromium.org/2485773003/diff/1/components/sync/driver/data...
components/sync/driver/data_type_manager_impl.cc:323: void
DataTypeManagerImpl::AdjustUnreadyTypeErrors(
nit: maybe call this UpdateUnreadyTypeErrors, rather than adjust? (since we're
updating to match the dtcs)

[pavely, 2016-11-09 01:29:45]

The CQ bit was checked by pavely@chromium.org

[pavely, 2016-11-09 01:29:45]

The patchset sent to the CQ was uploaded after l-g-t-m from zea@chromium.org
Link to the patchset: https://codereview.chromium.org/2485773003/#ps10001
(title: "Address comment from Nicolas.")

[commit-bot: I haz the power, 2016-11-09 01:30:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 03:24:51]

Committed patchset #2 (id:10001)

[commit-bot: I haz the power, 2016-11-09 03:28:55]

Description was changed from

==========
[Sync] Ensure unready types' state is updated before every reconfiguration

Problematic scenario involves one unready datatype:
- Perform normal configuration.
- Call ResetDataTypeErrors()
- Trigger reconfiguration through failure of some other datatype.
In this scenario DataTypeStatusTable::unready_errors_ is empty and
ModelAssociationManager attempts to call LoadModels for unready type.

In this change I move code to update unready_errors_ so it gets executed in
reconfiguration codepath as well as normal configure.

R=zea@chromium.org
BUG=661817
==========

to

==========
[Sync] Ensure unready types' state is updated before every reconfiguration

Problematic scenario involves one unready datatype:
- Perform normal configuration.
- Call ResetDataTypeErrors()
- Trigger reconfiguration through failure of some other datatype.
In this scenario DataTypeStatusTable::unready_errors_ is empty and
ModelAssociationManager attempts to call LoadModels for unready type.

In this change I move code to update unready_errors_ so it gets executed in
reconfiguration codepath as well as normal configure.

R=zea@chromium.org
BUG=661817

Committed: https://crrev.com/f09651efa84e17b879e82400422f4cfa87738ac3
Cr-Commit-Position: refs/heads/master@{#430843}
==========

[commit-bot: I haz the power, 2016-11-09 03:28:56]

Patchset 2 (id:??) landed as
https://crrev.com/f09651efa84e17b879e82400422f4cfa87738ac3
Cr-Commit-Position: refs/heads/master@{#430843}