Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2485773002: Enable ImageCapture origin trial experiment (Closed)

Created:
4 years, 1 month ago by mcasas
Modified:
4 years, 1 month ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable ImageCapture origin trial experiment Intent to Experiment discussion: https://groups.google.com/a/chromium.org/d/msg/Blink-dev/iAIKruoq5QM/Ht0eD081AwAJ BUG=603328, 518807 Committed: https://crrev.com/61d0cffac2d36bf46aac41d71ffa6deebd354382 Cr-Commit-Position: refs/heads/master@{#430652}

Patch Set 1 #

Total comments: 2

Patch Set 2 : reillyg@ comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/ImageCapture.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/MediaSettingsRange.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
mcasas
reillyg@ can you PTAL and verify I haven't forgotten something? Thx haraken@ RS please.
4 years, 1 month ago (2016-11-08 01:21:49 UTC) #2
haraken
LGTM but I think origin-trials would need a review of an API owner.
4 years, 1 month ago (2016-11-08 02:19:43 UTC) #8
tkent
lgtm
4 years, 1 month ago (2016-11-08 02:33:28 UTC) #9
Reilly Grant (use Gerrit)
lgtm https://codereview.chromium.org/2485773002/diff/1/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp File third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp (right): https://codereview.chromium.org/2485773002/diff/1/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp#newcode16 third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp:16: #include "bindings/modules/v8/V8ImageCapture.h" I don't think this include is ...
4 years, 1 month ago (2016-11-08 16:39:50 UTC) #10
mcasas
https://codereview.chromium.org/2485773002/diff/1/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp File third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp (right): https://codereview.chromium.org/2485773002/diff/1/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp#newcode16 third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp:16: #include "bindings/modules/v8/V8ImageCapture.h" On 2016/11/08 16:39:50, Reilly Grant wrote: > ...
4 years, 1 month ago (2016-11-08 16:43:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485773002/20001
4 years, 1 month ago (2016-11-08 16:44:09 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-08 18:12:39 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 18:38:31 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/61d0cffac2d36bf46aac41d71ffa6deebd354382
Cr-Commit-Position: refs/heads/master@{#430652}

Powered by Google App Engine
This is Rietveld 408576698