Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 2485763003: Remove access to WebContents in RWHVA::Focus() (Closed)

Created:
4 years, 1 month ago by Jinsuk Kim
Modified:
4 years, 1 month ago
Reviewers:
boliu
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove access to WebContents in RWHVA::Focus() Handles the layering violation in RWHVA::Focus() by moving the relevant part up to WebContentsAndroid. There is no functional changes. BUG=626765 Committed: https://crrev.com/ced620227dc7d5b43473251f75314bd22db969a9 Cr-Commit-Position: refs/heads/master@{#431101}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_view_android.cc View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Jinsuk Kim
4 years, 1 month ago (2016-11-08 16:50:35 UTC) #2
boliu
lgtm
4 years, 1 month ago (2016-11-08 17:03:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485763003/1
4 years, 1 month ago (2016-11-09 22:17:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 00:35:19 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 00:38:27 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ced620227dc7d5b43473251f75314bd22db969a9
Cr-Commit-Position: refs/heads/master@{#431101}

Powered by Google App Engine
This is Rietveld 408576698