Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2485753002: [ios] Unified CRWSessionController navigation logic. (Closed)

Created:
4 years, 1 month ago by Eugene But (OOO till 7-30)
Modified:
4 years, 1 month ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Unified CRWSessionController navigation logic. Changed -[CRWSessionController goToEntry:] logic to do the same things as goBack/goForward/goDelta: and made goDelta: call goToEntry:. goToEntry: is used when user navigates to session entry by doing a long press on back/forward button and picking an item from the dropdown, so it should work exacly the same as if user directly tapped back or forward. This refactoring will also allow to unify CRWWebController's goToItemAtIndex and goDelta. BUG=663072 Committed: https://crrev.com/d0b3868c2fee1da5c50b7b4d2d5c956835237b15 Cr-Commit-Position: refs/heads/master@{#430756}

Patch Set 1 #

Patch Set 2 : Rebased to origin/master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -21 lines) Patch
M ios/web/navigation/crw_session_controller.mm View 1 1 chunk +18 lines, -21 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Eugene But (OOO till 7-30)
4 years, 1 month ago (2016-11-07 22:54:25 UTC) #2
kkhorimoto
lgtm
4 years, 1 month ago (2016-11-07 23:14:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485753002/20001
4 years, 1 month ago (2016-11-08 23:14:38 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-08 23:30:16 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 23:38:28 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d0b3868c2fee1da5c50b7b4d2d5c956835237b15
Cr-Commit-Position: refs/heads/master@{#430756}

Powered by Google App Engine
This is Rietveld 408576698