Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2026)

Unified Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 2485693003: Drag-and-drop: DragEnter, DragOver, DragLeave, DragDrop (Closed)
Patch Set: No longer using GetSiteInstance() in RenderWidgetHostImpl. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_impl.h
diff --git a/content/browser/renderer_host/render_view_host_impl.h b/content/browser/renderer_host/render_view_host_impl.h
index 6a6a4c39231db34e10534ba28b4c00ec2c8a3651..87bfecb57b99de0acf02ff3fd3a21def7ea45418 100644
--- a/content/browser/renderer_host/render_view_host_impl.h
+++ b/content/browser/renderer_host/render_view_host_impl.h
@@ -107,30 +107,6 @@ class CONTENT_EXPORT RenderViewHostImpl : public RenderViewHost,
int screen_y,
blink::WebDragOperation operation) override;
void DragSourceSystemDragEnded() override;
- // |drop_data| must have been filtered. The embedder should call
- // FilterDropData before passing the drop data to RVHI.
- void DragTargetDragEnter(const DropData& drop_data,
- const gfx::Point& client_pt,
- const gfx::Point& screen_pt,
- blink::WebDragOperationsMask operations_allowed,
- int key_modifiers) override;
- void DragTargetDragEnterWithMetaData(
- const std::vector<DropData::Metadata>& metadata,
- const gfx::Point& client_pt,
- const gfx::Point& screen_pt,
- blink::WebDragOperationsMask operations_allowed,
- int key_modifiers) override;
- void DragTargetDragOver(const gfx::Point& client_pt,
- const gfx::Point& screen_pt,
- blink::WebDragOperationsMask operations_allowed,
- int key_modifiers) override;
- void DragTargetDragLeave() override;
- // |drop_data| must have been filtered. The embedder should call
- // FilterDropData before passing the drop data to RVHI.
- void DragTargetDrop(const DropData& drop_data,
- const gfx::Point& client_pt,
- const gfx::Point& screen_pt,
- int key_modifiers) override;
void FilterDropData(DropData* drop_data) override;
void EnableAutoResize(const gfx::Size& min_size,
const gfx::Size& max_size) override;
@@ -263,7 +239,7 @@ class CONTENT_EXPORT RenderViewHostImpl : public RenderViewHost,
// the caller places are in different platforms, in which case it's better
// to keep them consistent).
- protected:
+protected:
// RenderWidgetHostOwnerDelegate overrides.
bool OnMessageReceived(const IPC::Message& msg) override;
void RenderWidgetDidInit() override;
@@ -325,12 +301,6 @@ class CONTENT_EXPORT RenderViewHostImpl : public RenderViewHost,
// See https://crbug.com/304341.
WebPreferences ComputeWebkitPrefs();
- // 1. Grants permissions to URL (if any)
- // 2. Grants permissions to filenames
- // 3. Grants permissions to file system files.
- // 4. Register the files with the IsolatedContext.
- void GrantFileAccessFromDropData(DropData* drop_data);
-
// The RenderWidgetHost.
std::unique_ptr<RenderWidgetHostImpl> render_widget_host_;

Powered by Google App Engine
This is Rietveld 408576698