Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 2485693003: Drag-and-drop: DragEnter, DragOver, DragLeave, DragDrop (Closed)
Patch Set: Rebased. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.cpp ('k') | third_party/WebKit/public/web/WebFrameWidget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
index 150046a9863941541800192f1c1d8d5de68c4648..222d8472a7e7fd92e026e6f251f127949bf15d6e 100644
--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
@@ -1803,9 +1803,11 @@ static void DragAndDropURL(WebViewImpl* webView, const std::string& url) {
const WebPoint clientPoint(0, 0);
const WebPoint screenPoint(0, 0);
- webView->dragTargetDragEnter(dragData, clientPoint, screenPoint,
- WebDragOperationCopy, 0);
- webView->dragTargetDrop(dragData, clientPoint, screenPoint, 0);
+ ASSERT_TRUE(webView->widget()->isWebFrameWidget());
+ WebFrameWidget* widget = static_cast<WebFrameWidget*>(webView->widget());
dcheng 2016/11/09 20:23:16 Is it possible to just go through the main frame's
paulmeyer 2016/11/09 23:19:11 Yes, done.
+ widget->dragTargetDragEnter(dragData, clientPoint, screenPoint,
+ WebDragOperationCopy, 0);
+ widget->dragTargetDrop(dragData, clientPoint, screenPoint, 0);
FrameTestHelpers::pumpPendingRequestsForFrameToLoad(webView->mainFrame());
}
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.cpp ('k') | third_party/WebKit/public/web/WebFrameWidget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698