Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2485683002: Use AUTO_BOOKMARK for opening bookmarks on Android. (Closed)

Created:
4 years, 1 month ago by Ted C
Modified:
4 years, 1 month ago
Reviewers:
Ian Wen
CC:
chromium-reviews, tfarina, browser-components-watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use AUTO_BOOKMARK for opening bookmarks on Android. This was preventing bookmarks from appearing on the NTP. BUG= Committed: https://crrev.com/ecf789d37e9fe09aa1154cd9b27e4a03cfd14fa7 Cr-Commit-Position: refs/heads/master@{#430332}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ted C
PTAL
4 years, 1 month ago (2016-11-07 17:57:38 UTC) #2
Ian Wen
lgtm
4 years, 1 month ago (2016-11-07 18:12:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485683002/1
4 years, 1 month ago (2016-11-07 18:13:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 18:58:42 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 19:03:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ecf789d37e9fe09aa1154cd9b27e4a03cfd14fa7
Cr-Commit-Position: refs/heads/master@{#430332}

Powered by Google App Engine
This is Rietveld 408576698