Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: third_party/WebKit/Source/core/svg/SVGForeignObjectElement.cpp

Issue 2485663002: Store CSSPropertyID in SVGAnimatedPropertyBase (Closed)
Patch Set: Add missing case Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGForeignObjectElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGForeignObjectElement.cpp b/third_party/WebKit/Source/core/svg/SVGForeignObjectElement.cpp
index 16d5897f8770deffe63bfd70ab681ed321d5b035..d5966e2bc0877461447107387b3b7ae62d6df45e 100644
--- a/third_party/WebKit/Source/core/svg/SVGForeignObjectElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGForeignObjectElement.cpp
@@ -32,18 +32,21 @@ inline SVGForeignObjectElement::SVGForeignObjectElement(Document& document)
: SVGGraphicsElement(SVGNames::foreignObjectTag, document),
m_x(SVGAnimatedLength::create(this,
SVGNames::xAttr,
- SVGLength::create(SVGLengthMode::Width))),
+ SVGLength::create(SVGLengthMode::Width),
+ CSSPropertyX)),
m_y(SVGAnimatedLength::create(this,
SVGNames::yAttr,
- SVGLength::create(SVGLengthMode::Height))),
- m_width(
- SVGAnimatedLength::create(this,
- SVGNames::widthAttr,
- SVGLength::create(SVGLengthMode::Width))),
+ SVGLength::create(SVGLengthMode::Height),
+ CSSPropertyY)),
+ m_width(SVGAnimatedLength::create(this,
+ SVGNames::widthAttr,
+ SVGLength::create(SVGLengthMode::Width),
+ CSSPropertyWidth)),
m_height(
SVGAnimatedLength::create(this,
SVGNames::heightAttr,
- SVGLength::create(SVGLengthMode::Height))) {
+ SVGLength::create(SVGLengthMode::Height),
+ CSSPropertyHeight)) {
addToPropertyMap(m_x);
addToPropertyMap(m_y);
addToPropertyMap(m_width);
@@ -62,22 +65,6 @@ DEFINE_TRACE(SVGForeignObjectElement) {
DEFINE_NODE_FACTORY(SVGForeignObjectElement)
-bool SVGForeignObjectElement::isPresentationAttribute(
- const QualifiedName& name) const {
- if (name == SVGNames::xAttr || name == SVGNames::yAttr ||
- name == SVGNames::widthAttr || name == SVGNames::heightAttr)
- return true;
- return SVGGraphicsElement::isPresentationAttribute(name);
-}
-
-bool SVGForeignObjectElement::isPresentationAttributeWithSVGDOM(
- const QualifiedName& attrName) const {
- if (attrName == SVGNames::xAttr || attrName == SVGNames::yAttr ||
- attrName == SVGNames::widthAttr || attrName == SVGNames::heightAttr)
- return true;
- return SVGGraphicsElement::isPresentationAttributeWithSVGDOM(attrName);
-}
-
void SVGForeignObjectElement::collectStyleForPresentationAttribute(
const QualifiedName& name,
const AtomicString& value,
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGForeignObjectElement.h ('k') | third_party/WebKit/Source/core/svg/SVGImageElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698