Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGElement.cpp

Issue 2485663002: Store CSSPropertyID in SVGAnimatedPropertyBase (Closed)
Patch Set: Add missing case Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann
3 * <zimmermann@kde.org> 3 * <zimmermann@kde.org>
4 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org> 4 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org>
5 * Copyright (C) 2008 Apple Inc. All rights reserved. 5 * Copyright (C) 2008 Apple Inc. All rights reserved.
6 * Copyright (C) 2008 Alp Toker <alp@atoker.com> 6 * Copyright (C) 2008 Alp Toker <alp@atoker.com>
7 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 7 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 726 matching lines...) Expand 10 before | Expand all | Expand 10 after
737 return nullptr; 737 return nullptr;
738 738
739 return it->value.get(); 739 return it->value.get();
740 } 740 }
741 741
742 bool SVGElement::isAnimatableCSSProperty(const QualifiedName& attrName) { 742 bool SVGElement::isAnimatableCSSProperty(const QualifiedName& attrName) {
743 return animatedPropertyTypeForCSSAttribute(attrName) != AnimatedUnknown; 743 return animatedPropertyTypeForCSSAttribute(attrName) != AnimatedUnknown;
744 } 744 }
745 745
746 bool SVGElement::isPresentationAttribute(const QualifiedName& name) const { 746 bool SVGElement::isPresentationAttribute(const QualifiedName& name) const {
747 if (const SVGAnimatedPropertyBase* property = propertyFromAttribute(name))
748 return property->hasPresentationAttributeMapping();
747 return cssPropertyIdForSVGAttributeName(name) > 0; 749 return cssPropertyIdForSVGAttributeName(name) > 0;
748 } 750 }
749 751
752 bool SVGElement::isPresentationAttributeWithSVGDOM(
753 const QualifiedName& name) const {
754 const SVGAnimatedPropertyBase* property = propertyFromAttribute(name);
755 return property && property->hasPresentationAttributeMapping();
756 }
757
750 void SVGElement::collectStyleForPresentationAttribute( 758 void SVGElement::collectStyleForPresentationAttribute(
751 const QualifiedName& name, 759 const QualifiedName& name,
752 const AtomicString& value, 760 const AtomicString& value,
753 MutableStylePropertySet* style) { 761 MutableStylePropertySet* style) {
754 CSSPropertyID propertyID = cssPropertyIdForSVGAttributeName(name); 762 CSSPropertyID propertyID = cssPropertyIdForSVGAttributeName(name);
755 if (propertyID > 0) 763 if (propertyID > 0)
756 addPropertyToPresentationAttributeStyle(style, propertyID, value); 764 addPropertyToPresentationAttributeStyle(style, propertyID, value);
757 } 765 }
758 766
759 bool SVGElement::haveLoadedRequiredResources() { 767 bool SVGElement::haveLoadedRequiredResources() {
(...skipping 469 matching lines...) Expand 10 before | Expand all | Expand 10 after
1229 visitor->trace(m_className); 1237 visitor->trace(m_className);
1230 Element::trace(visitor); 1238 Element::trace(visitor);
1231 } 1239 }
1232 1240
1233 const AtomicString& SVGElement::eventParameterName() { 1241 const AtomicString& SVGElement::eventParameterName() {
1234 DEFINE_STATIC_LOCAL(const AtomicString, evtString, ("evt")); 1242 DEFINE_STATIC_LOCAL(const AtomicString, evtString, ("evt"));
1235 return evtString; 1243 return evtString;
1236 } 1244 }
1237 1245
1238 } // namespace blink 1246 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGElement.h ('k') | third_party/WebKit/Source/core/svg/SVGEllipseElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698