Cleanup and minor refactoring of LogDnsClient

Cleanup and minor refactoring of LogDnsClient

Given that a MerkleAuditProof only proves an inclusion path for a tree of a specific size, a tree_size parameter was added to it in  https://crrev.com/89f010d82559c73e7d23cbf067137ceb1df698df to keep track of which tree the proof was for. Because of this, it's no longer necessary to store the tree size separately in LogDnsClient::AuditProofQuery. Instead, it can just use the tree_size member of the MerkleAuditProof.

The QueryAuditProof method still takes the tree_size as a separate parameter, so as to not make the proof parameter a mixed in/out parameter, which could be confusing.

BUG=624894
Committed: https://crrev.com/5bfec4f1be40d333d92c0ebe200135be4928701c
Cr-Commit-Position: refs/heads/master@{#430604}

[Rob Percival, 2016-11-07 17:04:10]

The CQ bit was checked by robpercival@chromium.org to run a CQ dry run

[Rob Percival, 2016-11-07 17:04:31]

robpercival@chromium.org changed reviewers:
+ eranm@chromium.org

[Rob Percival, 2016-11-07 17:04:31]

PTAL

[commit-bot: I haz the power, 2016-11-07 17:04:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 17:52:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 17:53:00]

Dry run: This issue passed the CQ dry run.

[Ryan Sleevi, 2016-11-07 19:29:22]

rsleevi@chromium.org changed reviewers:
+ rsleevi@chromium.org

[Ryan Sleevi, 2016-11-07 19:29:23]

lgtm

[Ryan Sleevi, 2016-11-07 19:33:26]

Note: I gave the LG, but perhaps the description could be more clear. It covers
the "what", but doesn't cover the "why"

A terrible stab at writing this (I mean, really, it's terrible :P), but trying
to make sure at least I understand it well enough to state:

Given that a MerkleAuditProof only proves a merkle inclusion path to a tree of a
specific size, a tree_size parameter was added in https://crrev.com/foo to keep
track of what tree the proof was provided for. Because of this, it's no longer
necessary to pass the tree size explicitly as a parameter in the LogDnsClient,
as it can just use the tree_size member of the MerkleAuditProof for that
bookkeeping.

[Eran Messeri, 2016-11-07 20:34:05]

lgtm as well.

[Rob Percival, 2016-11-08 14:12:08]

Description was changed from

==========
Cleanup and minor refactoring of LogDnsClient

Now that MerkleAuditProof has a tree_size member, that can be used by
LogDnsClient.

BUG=624894
==========

to

==========
Cleanup and minor refactoring of LogDnsClient

Now that MerkleAuditProof has a tree_size member, that can be used by
LogDnsClient.

Given that a MerkleAuditProof only proves an inclusion path for a tree of a
specific size, a tree_size parameter was added to it in
https://crrev.com/89f010d82559c73e7d23cbf067137ceb1df698df to keep
track of which tree the proof was for. Because of this, it's no longer
necessary to store the tree size separately in LogDnsClient::AuditProofQuery.
Instead, it can just use the tree_size member of the MerkleAuditProof.

The QueryAuditProof method still takes the tree_size as a separate parameter, so
as to not make the proof parameter a mixed in/out parameter, which could be
confusing.

BUG=624894
==========

[Rob Percival, 2016-11-08 14:12:51]

Description was changed from

==========
Cleanup and minor refactoring of LogDnsClient

Now that MerkleAuditProof has a tree_size member, that can be used by
LogDnsClient.

Given that a MerkleAuditProof only proves an inclusion path for a tree of a
specific size, a tree_size parameter was added to it in
https://crrev.com/89f010d82559c73e7d23cbf067137ceb1df698df to keep
track of which tree the proof was for. Because of this, it's no longer
necessary to store the tree size separately in LogDnsClient::AuditProofQuery.
Instead, it can just use the tree_size member of the MerkleAuditProof.

The QueryAuditProof method still takes the tree_size as a separate parameter, so
as to not make the proof parameter a mixed in/out parameter, which could be
confusing.

BUG=624894
==========

to

==========
Cleanup and minor refactoring of LogDnsClient

Given that a MerkleAuditProof only proves an inclusion path for a tree of a
specific size, a tree_size parameter was added to it in 
https://crrev.com/89f010d82559c73e7d23cbf067137ceb1df698df to keep track of
which tree the proof was for. Because of this, it's no longer necessary to store
the tree size separately in LogDnsClient::AuditProofQuery. Instead, it can just
use the tree_size member of the MerkleAuditProof.

The QueryAuditProof method still takes the tree_size as a separate parameter, so
as to not make the proof parameter a mixed in/out parameter, which could be
confusing.

BUG=624894
==========

[Rob Percival, 2016-11-08 14:13:20]

The CQ bit was checked by robpercival@chromium.org

[commit-bot: I haz the power, 2016-11-08 14:13:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 14:17:30]

Description was changed from

==========
Cleanup and minor refactoring of LogDnsClient

Given that a MerkleAuditProof only proves an inclusion path for a tree of a
specific size, a tree_size parameter was added to it in 
https://crrev.com/89f010d82559c73e7d23cbf067137ceb1df698df to keep track of
which tree the proof was for. Because of this, it's no longer necessary to store
the tree size separately in LogDnsClient::AuditProofQuery. Instead, it can just
use the tree_size member of the MerkleAuditProof.

The QueryAuditProof method still takes the tree_size as a separate parameter, so
as to not make the proof parameter a mixed in/out parameter, which could be
confusing.

BUG=624894
==========

to

==========
Cleanup and minor refactoring of LogDnsClient

Given that a MerkleAuditProof only proves an inclusion path for a tree of a
specific size, a tree_size parameter was added to it in 
https://crrev.com/89f010d82559c73e7d23cbf067137ceb1df698df to keep track of
which tree the proof was for. Because of this, it's no longer necessary to store
the tree size separately in LogDnsClient::AuditProofQuery. Instead, it can just
use the tree_size member of the MerkleAuditProof.

The QueryAuditProof method still takes the tree_size as a separate parameter, so
as to not make the proof parameter a mixed in/out parameter, which could be
confusing.

BUG=624894
==========

[commit-bot: I haz the power, 2016-11-08 14:17:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-08 14:18:51]

Description was changed from

==========
Cleanup and minor refactoring of LogDnsClient

Given that a MerkleAuditProof only proves an inclusion path for a tree of a
specific size, a tree_size parameter was added to it in 
https://crrev.com/89f010d82559c73e7d23cbf067137ceb1df698df to keep track of
which tree the proof was for. Because of this, it's no longer necessary to store
the tree size separately in LogDnsClient::AuditProofQuery. Instead, it can just
use the tree_size member of the MerkleAuditProof.

The QueryAuditProof method still takes the tree_size as a separate parameter, so
as to not make the proof parameter a mixed in/out parameter, which could be
confusing.

BUG=624894
==========

to

==========
Cleanup and minor refactoring of LogDnsClient

Given that a MerkleAuditProof only proves an inclusion path for a tree of a
specific size, a tree_size parameter was added to it in 
https://crrev.com/89f010d82559c73e7d23cbf067137ceb1df698df to keep track of
which tree the proof was for. Because of this, it's no longer necessary to store
the tree size separately in LogDnsClient::AuditProofQuery. Instead, it can just
use the tree_size member of the MerkleAuditProof.

The QueryAuditProof method still takes the tree_size as a separate parameter, so
as to not make the proof parameter a mixed in/out parameter, which could be
confusing.

BUG=624894

Committed: https://crrev.com/5bfec4f1be40d333d92c0ebe200135be4928701c
Cr-Commit-Position: refs/heads/master@{#430604}
==========

[commit-bot: I haz the power, 2016-11-08 14:18:52]

Patchset 1 (id:??) landed as
https://crrev.com/5bfec4f1be40d333d92c0ebe200135be4928701c
Cr-Commit-Position: refs/heads/master@{#430604}