Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2485633003: SuggestionsSource cleanup: Remove TaskRunnerForRequestPath implementation (Closed)

Created:
4 years, 1 month ago by Marc Treib
Modified:
4 years, 1 month ago
Reviewers:
gab
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SuggestionsSource cleanup: Remove TaskRunnerForRequestPath implementation It's identical to the base class implementation, so it's pointless and confusing to have it. BUG=661733 Committed: https://crrev.com/b818840a8c8b23730a0485839ab9a7782a1b238b Cr-Commit-Position: refs/heads/master@{#430597}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M chrome/browser/search/suggestions/suggestions_ui.cc View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Marc Treib
PTAL!
4 years, 1 month ago (2016-11-08 12:57:21 UTC) #4
gab
lgtm, thanks!
4 years, 1 month ago (2016-11-08 13:35:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485633003/1
4 years, 1 month ago (2016-11-08 13:37:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 13:41:05 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 13:43:21 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b818840a8c8b23730a0485839ab9a7782a1b238b
Cr-Commit-Position: refs/heads/master@{#430597}

Powered by Google App Engine
This is Rietveld 408576698