Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2485633002: bluetooth: mac: Removing #pragma clang diagnostic ignored "-Wpartial-availability" (Closed)

Created:
4 years, 1 month ago by jlebel
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: mac: Removing #pragma clang diagnostic ignored "-Wpartial-availability" Now the macOS version target is 10.9, therefore the definition of -[<CBPeripheralDelegate> peripheral:didModifyServices:] is known by the bot compilers. Note that this method is optional for <CBPeripheralDelegate>. BUG=653056 Committed: https://crrev.com/d9c107f9476d72220f6ab128578183ba9f1b18f6 Cr-Commit-Position: refs/heads/master@{#430405}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M device/bluetooth/test/mock_bluetooth_cbperipheral_mac.mm View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jlebel
Hello, This patch is to remove #pragma that was required by 10.8 support. Thanks,
4 years, 1 month ago (2016-11-07 15:51:35 UTC) #2
ortuno
lgtm
4 years, 1 month ago (2016-11-07 20:58:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485633002/1
4 years, 1 month ago (2016-11-07 21:41:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 22:44:14 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 23:01:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9c107f9476d72220f6ab128578183ba9f1b18f6
Cr-Commit-Position: refs/heads/master@{#430405}

Powered by Google App Engine
This is Rietveld 408576698