discardable_memory: Using mojo IPC to replace Chrome IPC

content/ppapi_plugin/ppapi_thread.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/ppapi_plugin/ppapi_thread.h"
 
 #include <stddef.h>
 
 #include <limits>
 
@@ skipping 89 matching lines @@
 }
 
 #endif
 
 namespace content {
 
 typedef int32_t (*InitializeBrokerFunc)
     (PP_ConnectInstance_Func* connect_instance_func);
 
 PpapiThread::PpapiThread(const base::CommandLine& command_line, bool is_broker)
-    : is_broker_(is_broker),
+    : ChildThreadImpl(Options::Builder()
+                          .InitDiscardableMemory(
+                              !command_line.HasSwitch(switches::kSingleProcess))

[reveman, 2016/11/18 21:55:26]

sorry if I asked this already but would it be possible to just init this even in
the single process case? and in that way remove the need for a builder option..

[Peng, 2016/11/21 15:56:39]

Done

[Peng, 2016/11/21 18:31:42]

Sorry. I just tried it. But the content_browsertest crashes. It is because the
content browsertest will set this flag, but we still need initial the client
discardable shared memory manager for it. So we cannot test this flags in
ChildThreadImpl.

+                          .Build()),
+      is_broker_(is_broker),
       plugin_globals_(GetIOTaskRunner()),
       connect_instance_func_(NULL),
       local_pp_module_(base::RandInt(0, std::numeric_limits<PP_Module>::max())),
       next_plugin_dispatcher_id_(1) {
   plugin_globals_.SetPluginProxyDelegate(this);
   plugin_globals_.set_command_line(
       command_line.GetSwitchValueASCII(switches::kPpapiFlashArgs));
 
   blink_platform_impl_.reset(new PpapiBlinkPlatformImpl);
   blink::Platform::initialize(blink_platform_impl_.get());
@@ skipping 450 matching lines @@
           GetHistogramName(is_broker_, "LoadTime", path),
           base::TimeDelta::FromMilliseconds(1),
           base::TimeDelta::FromSeconds(10),
           50,
           base::HistogramBase::kUmaTargetedHistogramFlag);
 
   histogram->AddTime(load_time);
 }
 
 }  // namespace content