Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2485573004: Fix locked/unlocked in SW IDC memory dumps. (Closed)

Created:
4 years, 1 month ago by ericrk
Modified:
4 years, 1 month ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix locked/unlocked in SW IDC memory dumps. Refactored this incorrectly in the last CL. R=vmpstr BUG=661948 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/4ce5368e828e3aaabbede4a684fdc705288b48c9 Cr-Commit-Position: refs/heads/master@{#430396}

Patch Set 1 #

Patch Set 2 : comment #

Patch Set 3 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M cc/tiles/software_image_decode_controller.cc View 1 2 1 chunk +10 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
ericrk
4 years, 1 month ago (2016-11-07 19:42:57 UTC) #2
ericrk
Added a comment and re-formatted.
4 years, 1 month ago (2016-11-07 19:50:30 UTC) #4
vmpstr
lgtm
4 years, 1 month ago (2016-11-07 19:50:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485573004/40001
4 years, 1 month ago (2016-11-07 19:59:10 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-07 22:15:30 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 22:26:11 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4ce5368e828e3aaabbede4a684fdc705288b48c9
Cr-Commit-Position: refs/heads/master@{#430396}

Powered by Google App Engine
This is Rietveld 408576698