Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2485573003: Functions to create and manipulate x-callback-url URLs. (Closed)

Created:
4 years, 1 month ago by sdefresne
Modified:
4 years, 1 month ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Functions to create and manipulate x-callback-url URLs. See http://x-callback-url.com/specifications/ for the specification of x-callback-url URLs. BUG=653086 Committed: https://crrev.com/5db5553160affb9ea2464666320c3855e5d203d2 Cr-Commit-Position: refs/heads/master@{#430571}

Patch Set 1 #

Total comments: 10

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+318 lines, -0 lines) Patch
M ios/chrome/common/BUILD.gn View 3 chunks +5 lines, -0 lines 0 comments Download
M ios/chrome/common/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A ios/chrome/common/x_callback_url.h View 1 chunk +38 lines, -0 lines 0 comments Download
A ios/chrome/common/x_callback_url.cc View 1 1 chunk +95 lines, -0 lines 0 comments Download
A ios/chrome/common/x_callback_url_unittest.cc View 1 1 chunk +179 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (10 generated)
sdefresne
rohitrao: please take a look. mef: please review new DEPS on //net from //ios/chrome/common.
4 years, 1 month ago (2016-11-07 17:50:10 UTC) #4
rohitrao (ping after 24h)
lgtm https://codereview.chromium.org/2485573003/diff/1/ios/chrome/common/x_callback_url.cc File ios/chrome/common/x_callback_url.cc (right): https://codereview.chromium.org/2485573003/diff/1/ios/chrome/common/x_callback_url.cc#newcode40 ios/chrome/common/x_callback_url.cc:40: GURL url(base::StringPrintf("%s://%s/%s", scheme.data(), kXCallbackURLHost, Is there any way ...
4 years, 1 month ago (2016-11-07 17:58:17 UTC) #5
mef
lgtm https://codereview.chromium.org/2485573003/diff/1/ios/chrome/common/x_callback_url.cc File ios/chrome/common/x_callback_url.cc (right): https://codereview.chromium.org/2485573003/diff/1/ios/chrome/common/x_callback_url.cc#newcode44 ios/chrome/common/x_callback_url.cc:44: url = net::AppendQueryParameter(url, kSuccessURLParameterName, On 2016/11/07 17:58:17, rohitrao ...
4 years, 1 month ago (2016-11-07 18:42:10 UTC) #6
sdefresne
Thank you for the review. https://codereview.chromium.org/2485573003/diff/1/ios/chrome/common/x_callback_url.cc File ios/chrome/common/x_callback_url.cc (right): https://codereview.chromium.org/2485573003/diff/1/ios/chrome/common/x_callback_url.cc#newcode40 ios/chrome/common/x_callback_url.cc:40: GURL url(base::StringPrintf("%s://%s/%s", scheme.data(), kXCallbackURLHost, ...
4 years, 1 month ago (2016-11-08 07:15:28 UTC) #9
sdefresne
https://codereview.chromium.org/2485573003/diff/1/ios/chrome/common/x_callback_url_unittest.cc File ios/chrome/common/x_callback_url_unittest.cc (right): https://codereview.chromium.org/2485573003/diff/1/ios/chrome/common/x_callback_url_unittest.cc#newcode24 ios/chrome/common/x_callback_url_unittest.cc:24: EXPECT_TRUE(IsXCallbackURL(GURL("chrome://x-callback-url"))); On 2016/11/07 18:42:10, mef wrote: > Maybe add ...
4 years, 1 month ago (2016-11-08 07:20:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485573003/20001
4 years, 1 month ago (2016-11-08 08:05:54 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-08 10:40:34 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 10:45:20 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5db5553160affb9ea2464666320c3855e5d203d2
Cr-Commit-Position: refs/heads/master@{#430571}

Powered by Google App Engine
This is Rietveld 408576698