Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2485563002: [turbofan] Properly rename receiver on CheckHeapObject. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly rename receiver on CheckHeapObject. We need to rename the receiver on CheckHeapObject, because we don't canonicalize numbers in SignedSmall range, and thus we the representation selection can hand out TaggedSigned values for receiver uses, even though we checked for TaggedPointerness first. Note that this is rather hacky and just intended to fix the bug ASAP. We need to think about how to deal with representations in earlier compilation stages. BUG=chromium:662410 R=jarin@chromium.org Committed: https://crrev.com/a758c19761ce6722836363ab9a5ed4437897197c Cr-Commit-Position: refs/heads/master@{#40792}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -46 lines) Patch
M src/compiler/js-builtin-reducer.cc View 4 chunks +16 lines, -3 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 2 chunks +14 lines, -1 line 0 comments Download
M src/compiler/js-inlining.cc View 2 chunks +14 lines, -1 line 0 comments Download
M src/compiler/js-native-context-specialization.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 4 chunks +6 lines, -30 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-662410.js View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 1 month ago (2016-11-07 08:17:02 UTC) #1
Jarin
lgtm
4 years, 1 month ago (2016-11-07 08:21:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485563002/1
4 years, 1 month ago (2016-11-07 08:22:17 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 08:41:14 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:24:12 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a758c19761ce6722836363ab9a5ed4437897197c
Cr-Commit-Position: refs/heads/master@{#40792}

Powered by Google App Engine
This is Rietveld 408576698