Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2485543004: Make SurfaceFactory lifetime match frame_sink_id registration in OffscreenCanvasCompositorFrameSink (Closed)

Created:
4 years, 1 month ago by piman
Modified:
4 years, 1 month ago
Reviewers:
xidachen, xlai (Olivia)
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make SurfaceFactory lifetime match frame_sink_id registration in OffscreenCanvasCompositorFrameSink This will allow further simplification/refactoring. BUG=657959 Committed: https://crrev.com/ba306aec9d9b09a427c4f95f095a8c039c56691a Cr-Commit-Position: refs/heads/master@{#430667}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -19 lines) Patch
M content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc View 2 chunks +15 lines, -19 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
piman
4 years, 1 month ago (2016-11-07 22:39:20 UTC) #4
xidachen
This change looks good. xlai@: you are more familiar with this part, could you please ...
4 years, 1 month ago (2016-11-08 01:25:42 UTC) #8
xlai (Olivia)
On 2016/11/08 01:25:42, xidachen wrote: > This change looks good. > > xlai@: you are ...
4 years, 1 month ago (2016-11-08 15:51:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485543004/1
4 years, 1 month ago (2016-11-08 18:29:36 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 18:37:13 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 19:08:33 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba306aec9d9b09a427c4f95f095a8c039c56691a
Cr-Commit-Position: refs/heads/master@{#430667}

Powered by Google App Engine
This is Rietveld 408576698