Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 2485543002: [turbofan] Also track Float64 fields in LoadElimination (on 64-bit platforms). (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Also track Float64 fields in LoadElimination (on 64-bit platforms). This adds support to track Float64 fields on 64-bit platforms, which is necessary to properly deal with unboxed double fields there. Drive-by-fix: Crash if we see Simd128 representation here. R=jarin@chromium.org BUG=v8:5608 Committed: https://crrev.com/76bd4ff492c50ff6f066b76bc98ea5714b7236d0 Cr-Commit-Position: refs/heads/master@{#40788}

Patch Set 1 #

Patch Set 2 : Address redness. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M src/compiler/load-elimination.cc View 1 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Benedikt Meurer
4 years, 1 month ago (2016-11-07 05:26:33 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the first part of the LoadElimination fixes. Please take a look. Thanks, ...
4 years, 1 month ago (2016-11-07 05:31:16 UTC) #4
Jarin
lgtm
4 years, 1 month ago (2016-11-07 06:44:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485543002/20001
4 years, 1 month ago (2016-11-07 06:45:05 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-07 06:48:17 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:24:01 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/76bd4ff492c50ff6f066b76bc98ea5714b7236d0
Cr-Commit-Position: refs/heads/master@{#40788}

Powered by Google App Engine
This is Rietveld 408576698