android_webview/native/popup_touch_handle_drawable.cc - Issue 2485513003: Rename JavaObjectWeakGlobalRef::is_empty to avoid misuse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/popup_touch_handle_drawable.cc

Issue 2485513003: Rename JavaObjectWeakGlobalRef::is_empty to avoid misuse. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/native/popup_touch_handle_drawable.cc

diff --git a/android_webview/native/popup_touch_handle_drawable.cc b/android_webview/native/popup_touch_handle_drawable.cc

index d46122cc8e0ab2ab48e4a0ff0ea80a5134ecf82a..0ba52f1b45a6b85ba8542bd18cd8dad57da375ac 100644

--- a/android_webview/native/popup_touch_handle_drawable.cc

+++ b/android_webview/native/popup_touch_handle_drawable.cc

@@ -17,7 +17,7 @@ PopupTouchHandleDrawable::PopupTouchHandleDrawable(

float horizontal_padding_ratio)

: java_ref_(env, obj)

, drawable_horizontal_padding_ratio_(horizontal_padding_ratio) {

- DCHECK(!java_ref_.is_empty());

+ DCHECK(obj);

}

PopupTouchHandleDrawable::~PopupTouchHandleDrawable() {