Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: base/android/jni_weak_ref.h

Issue 2485513003: Rename JavaObjectWeakGlobalRef::is_empty to avoid misuse. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_ANDROID_JNI_WEAK_REF_H_ 5 #ifndef BASE_ANDROID_JNI_WEAK_REF_H_
6 #define BASE_ANDROID_JNI_WEAK_REF_H_ 6 #define BASE_ANDROID_JNI_WEAK_REF_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 9
10 #include "base/android/scoped_java_ref.h" 10 #include "base/android/scoped_java_ref.h"
(...skipping 11 matching lines...) Expand all
22 JavaObjectWeakGlobalRef(JNIEnv* env, jobject obj); 22 JavaObjectWeakGlobalRef(JNIEnv* env, jobject obj);
23 JavaObjectWeakGlobalRef(JNIEnv* env, 23 JavaObjectWeakGlobalRef(JNIEnv* env,
24 const base::android::JavaRef<jobject>& obj); 24 const base::android::JavaRef<jobject>& obj);
25 virtual ~JavaObjectWeakGlobalRef(); 25 virtual ~JavaObjectWeakGlobalRef();
26 26
27 void operator=(const JavaObjectWeakGlobalRef& rhs); 27 void operator=(const JavaObjectWeakGlobalRef& rhs);
28 void operator=(JavaObjectWeakGlobalRef&& rhs); 28 void operator=(JavaObjectWeakGlobalRef&& rhs);
29 29
30 base::android::ScopedJavaLocalRef<jobject> get(JNIEnv* env) const; 30 base::android::ScopedJavaLocalRef<jobject> get(JNIEnv* env) const;
31 31
32 bool is_empty() const { return obj_ == nullptr; } 32 // Returns true if the weak reference has not been initialized to point at
33 // an object (or ḣas had reset() called).
34 // Do not call this to test if the object referred to still exists! The weak
35 // reference remains initialized even if the target object has been collected.
36 bool is_uninitialized() const { return obj_ == nullptr; }
33 37
34 void reset(); 38 void reset();
35 39
36 private: 40 private:
37 void Assign(const JavaObjectWeakGlobalRef& rhs); 41 void Assign(const JavaObjectWeakGlobalRef& rhs);
38 42
39 jweak obj_; 43 jweak obj_;
40 }; 44 };
41 45
42 // Get the real object stored in the weak reference returned as a 46 // Get the real object stored in the weak reference returned as a
43 // ScopedJavaLocalRef. 47 // ScopedJavaLocalRef.
44 BASE_EXPORT base::android::ScopedJavaLocalRef<jobject> GetRealObject( 48 BASE_EXPORT base::android::ScopedJavaLocalRef<jobject> GetRealObject(
45 JNIEnv* env, jweak obj); 49 JNIEnv* env, jweak obj);
46 50
47 #endif // BASE_ANDROID_JNI_WEAK_REF_H_ 51 #endif // BASE_ANDROID_JNI_WEAK_REF_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698