Show warning dialog when user installs WebAPK when "installation from Unknown sources" is disabled

Show warning dialog when user installs WebAPK when "installation from Unknown sources" is disabled

Currently, we detect if "installation from Unknown sources" is disabled and
cause installation to silently fail. This behavior is confusing. This CL
changes the behavior to show a warning dialog telling the user that the
installation was blocked with a button to go to "Android Security Settings".
This behavior is provided by default by the Android OS when an intent is sent to
install an APK when "installation from Unknown sources" is disabled.

BUG=662739
Committed: https://crrev.com/01ae00b9a5dbef08b338551f9e5d050059ecec1c
Cr-Commit-Position: refs/heads/master@{#430361}

[pkotwicz, 2016-11-06 19:44:38]

Description was changed from

==========
Show warning dialog when user installs WebAPK when "installation from Unknown
sources" is disabled

We used to detect if "installation from Unknown sources" was disabled and
installation would silently fail. This behavior is confusing. This CL reverts
the behavior when "installation from Unknown sources" is disabled to the default
behavior. By default, Android shows a warning dialog telling the user that the
installation was blocked with a button to go to "Android Security Settings"

BUG=662739
==========

to

==========
Show warning dialog when user installs WebAPK when "installation from Unknown
sources" is disabled

Currently, we detect if "installation from Unknown sources" is disabled and
cause installation to silently fail. This behavior is confusing. This CL
changes the behavior to show a warning dialog telling the user that the
installation was blocked with a button to go to "Android Security Settings".
This behavior is provided by default by the Android OS when an intent is sent to
install an APK when "installation from Unknown sources" is disabled.

BUG=662739
==========

[pkotwicz, 2016-11-06 19:44:38]

pkotwicz@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[pkotwicz, 2016-11-06 19:45:08]

Dan, can you please take a look?

[pkotwicz, 2016-11-06 19:46:27]

pkotwicz@chromium.org changed reviewers:
+ hanxi@chromium.org

[gone, 2016-11-07 18:29:41]

lgtm

[pkotwicz, 2016-11-07 19:47:03]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-11-07 19:47:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 20:37:25]

Description was changed from

==========
Show warning dialog when user installs WebAPK when "installation from Unknown
sources" is disabled

Currently, we detect if "installation from Unknown sources" is disabled and
cause installation to silently fail. This behavior is confusing. This CL
changes the behavior to show a warning dialog telling the user that the
installation was blocked with a button to go to "Android Security Settings".
This behavior is provided by default by the Android OS when an intent is sent to
install an APK when "installation from Unknown sources" is disabled.

BUG=662739
==========

to

==========
Show warning dialog when user installs WebAPK when "installation from Unknown
sources" is disabled

Currently, we detect if "installation from Unknown sources" is disabled and
cause installation to silently fail. This behavior is confusing. This CL
changes the behavior to show a warning dialog telling the user that the
installation was blocked with a button to go to "Android Security Settings".
This behavior is provided by default by the Android OS when an intent is sent to
install an APK when "installation from Unknown sources" is disabled.

BUG=662739
==========

[commit-bot: I haz the power, 2016-11-07 20:37:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-07 21:18:47]

Description was changed from

==========
Show warning dialog when user installs WebAPK when "installation from Unknown
sources" is disabled

Currently, we detect if "installation from Unknown sources" is disabled and
cause installation to silently fail. This behavior is confusing. This CL
changes the behavior to show a warning dialog telling the user that the
installation was blocked with a button to go to "Android Security Settings".
This behavior is provided by default by the Android OS when an intent is sent to
install an APK when "installation from Unknown sources" is disabled.

BUG=662739
==========

to

==========
Show warning dialog when user installs WebAPK when "installation from Unknown
sources" is disabled

Currently, we detect if "installation from Unknown sources" is disabled and
cause installation to silently fail. This behavior is confusing. This CL
changes the behavior to show a warning dialog telling the user that the
installation was blocked with a button to go to "Android Security Settings".
This behavior is provided by default by the Android OS when an intent is sent to
install an APK when "installation from Unknown sources" is disabled.

BUG=662739

Committed: https://crrev.com/01ae00b9a5dbef08b338551f9e5d050059ecec1c
Cr-Commit-Position: refs/heads/master@{#430361}
==========

[commit-bot: I haz the power, 2016-11-07 21:18:48]

Patchset 1 (id:??) landed as
https://crrev.com/01ae00b9a5dbef08b338551f9e5d050059ecec1c
Cr-Commit-Position: refs/heads/master@{#430361}