Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2765)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: cc/surfaces/surface_unittest.cc

Issue 2485473003: Remove SurfaceFactory::Create and SurfaceFactory::Destroy (Closed)
Patch Set: fixed windows compile error Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cc/surfaces/surface_factory.cc ('K') | « cc/surfaces/surface_manager_ref_unittest.cc ('k') | cc/surfaces/surfaces_pixeltest.cc » ('j') | content/browser/renderer_host/delegated_frame_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/surface_unittest.cc
diff --git a/cc/surfaces/surface_unittest.cc b/cc/surfaces/surface_unittest.cc
index 5b8e614f4fefa3d970a774f9de96710ff968a1e8..b2d65e93572e0fe469533ad067d7210183ca4a7c 100644
--- a/cc/surfaces/surface_unittest.cc
+++ b/cc/surfaces/surface_unittest.cc
@@ -40,11 +40,10 @@ TEST(SurfaceTest, SurfaceLifetime) {
LocalFrameId local_frame_id(6, base::UnguessableToken::Create());
SurfaceId surface_id(kArbitraryFrameSinkId, local_frame_id);
- {
- factory.Create(local_frame_id);
- EXPECT_TRUE(manager.GetSurfaceForId(surface_id));
- factory.Destroy(local_frame_id);
- }
+ factory.SubmitCompositorFrame(local_frame_id, CompositorFrame(),
+ SurfaceFactory::DrawCallback());
+ EXPECT_TRUE(manager.GetSurfaceForId(surface_id));
+ factory.EvictSurface();
EXPECT_EQ(NULL, manager.GetSurfaceForId(surface_id));
}
« cc/surfaces/surface_factory.cc ('K') | « cc/surfaces/surface_manager_ref_unittest.cc ('k') | cc/surfaces/surfaces_pixeltest.cc » ('j') | content/browser/renderer_host/delegated_frame_host.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698