Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4210)

Unified Diff: cc/surfaces/surface_unittest.cc

Issue 2485473003: Remove SurfaceFactory::Create and SurfaceFactory::Destroy (Closed)
Patch Set: doc Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/surfaces/surface_unittest.cc
diff --git a/cc/surfaces/surface_unittest.cc b/cc/surfaces/surface_unittest.cc
index 5b8e614f4fefa3d970a774f9de96710ff968a1e8..760acb1546d4d233e23ad22e738b9789d9136578 100644
--- a/cc/surfaces/surface_unittest.cc
+++ b/cc/surfaces/surface_unittest.cc
@@ -41,9 +41,10 @@ TEST(SurfaceTest, SurfaceLifetime) {
LocalFrameId local_frame_id(6, base::UnguessableToken::Create());
SurfaceId surface_id(kArbitraryFrameSinkId, local_frame_id);
{
danakj 2016/11/15 00:43:41 nit: these {} are pointless but distract from what
Saman Sami 2016/11/15 21:12:19 Done.
- factory.Create(local_frame_id);
+ factory.SubmitCompositorFrame(local_frame_id, CompositorFrame(),
+ SurfaceFactory::DrawCallback());
EXPECT_TRUE(manager.GetSurfaceForId(surface_id));
- factory.Destroy(local_frame_id);
+ factory.EvictSurface();
}
EXPECT_EQ(NULL, manager.GetSurfaceForId(surface_id));

Powered by Google App Engine
This is Rietveld 408576698